Skip to content

bump(cargo)!: 🚀 upgrades available#1308

Merged
qmonnet merged 5 commits intomainfrom
bump/cargo-upgrades
Mar 5, 2026
Merged

bump(cargo)!: 🚀 upgrades available#1308
qmonnet merged 5 commits intomainfrom
bump/cargo-upgrades

Conversation

@hedgehog-dataplane-update
Copy link
Contributor

🚀 Upgrades available

name      old req compatible latest  new req
====      ======= ========== ======  =======
chrono    0.4.43  0.4.44     0.4.44  0.4.44 
nix       0.31.1  0.31.2     0.31.2  0.31.2 
pyroscope 0.5.8   0.5.8      1.0.1   1.0.1  
rustls    0.23.36 0.23.37    0.23.37 0.23.37

⚠️ This Pull Request was automatically generated and should be carefully reviewed before acceptance. It may introduce breaking changes.

@hedgehog-dataplane-update hedgehog-dataplane-update bot requested a review from a team as a code owner March 2, 2026 04:03
@hedgehog-dataplane-update hedgehog-dataplane-update bot added the dependencies Pull requests that update a dependency file label Mar 2, 2026
@hedgehog-dataplane-update hedgehog-dataplane-update bot requested review from sergeymatov and removed request for a team March 2, 2026 04:03
@qmonnet
Copy link
Member

qmonnet commented Mar 2, 2026

The major version update for pyroscope is breaking. @sergeymatov can you please take a look?

@qmonnet qmonnet assigned sergeymatov and unassigned sergeymatov Mar 2, 2026
@qmonnet
Copy link
Member

qmonnet commented Mar 2, 2026

@qmonnet
Copy link
Member

qmonnet commented Mar 2, 2026

@qmonnet qmonnet self-requested a review March 5, 2026 10:24
"hedgehog-dataplane",
100u32,
"pyroscope-rs",
"1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this version number? I see it matches the version from the pyroscope crate. Is it supposed to remain in sync? If so I'm concerned that we'll miss it next time we get an automatic bump for the crate 🙀. Do you know what happens if it's not in sync with the dependency crate (does it break at compile time, in which case we'll easily detect and fix for future upgrades, or does it possibly introduce bugs, or would it still be expected to work)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good question that I spent some time figuring out the correct values. And here what I have so far

pub fn new(
        url: impl AsRef<str>,
        application_name: impl AsRef<str>,
        sample_rate: u32,
        spy_name: impl AsRef<str>,
        spy_version: impl AsRef<str>,
        backend: BackendImpl<BackendUninitialized>,

where spy_name and spy_version corresponds to the profiler running in current application. In Dataplane we are using pyroscope-rs and current create version of it is 1.0.1. I can't find any other doc related to this particular variable unfortunately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pity we've got to update that number in addition to the version in Cargo.toml 😞 but not much we can do about it I guess. Thanks

@sergeymatov sergeymatov force-pushed the bump/cargo-upgrades branch 3 times, most recently from 3271fa8 to e232393 Compare March 5, 2026 11:11
hedgehog-dataplane-update bot and others added 5 commits March 5, 2026 12:52
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
name   old req compatible latest new req
====   ======= ========== ====== =======
chrono 0.4.43  0.4.44     0.4.44 0.4.44

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
name old req compatible latest new req
==== ======= ========== ====== =======
nix  0.31.1  0.31.2     0.31.2 0.31.2

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
name      old req compatible latest new req
====      ======= ========== ====== =======
pyroscope 0.5.8   0.5.8      1.0.1  1.0.1

[ Sergey: Address breaking change ]
[ Quentin: Bump 1.0.1->1.0.2, comment to tell to keep versions in sync ]

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sergey Matov <[email protected]>
Signed-off-by: Quentin Monnet <[email protected]>
name   old req compatible latest  new req
====   ======= ========== ======  =======
rustls 0.23.36 0.23.37    0.23.37 0.23.37

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@qmonnet qmonnet force-pushed the bump/cargo-upgrades branch from e232393 to e56813c Compare March 5, 2026 12:09
@qmonnet
Copy link
Member

qmonnet commented Mar 5, 2026

@sergeymatov I forced-pushed on your branch:

  • I rebased on the current main
  • I squashed your fix into the pyroscope update
  • I bumped pyroscope to 1.0.2 (now that it's out)
  • I added a comment in Cargo.toml as well as the Rust file, to help remembering to update the version number.

@qmonnet qmonnet enabled auto-merge March 5, 2026 12:13
@sergeymatov
Copy link
Contributor

@qmonnet thanks for adjustments and cleanup. Much appreciated

@qmonnet qmonnet added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit ebfaf98 Mar 5, 2026
28 of 30 checks passed
@qmonnet qmonnet deleted the bump/cargo-upgrades branch March 5, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants