Conversation
|
The major version update for |
|
I think this is the breaking change: grafana/pyroscope-rs@8ab8bc7#diff-9d372ec50bcb337bf0a01889d97d230d6d235bb15487175a17e4c7a1456ce285 |
dataplane/src/main.rs
Outdated
| "hedgehog-dataplane", | ||
| 100u32, | ||
| "pyroscope-rs", | ||
| "1.0.1", |
There was a problem hiding this comment.
What is this version number? I see it matches the version from the pyroscope crate. Is it supposed to remain in sync? If so I'm concerned that we'll miss it next time we get an automatic bump for the crate 🙀. Do you know what happens if it's not in sync with the dependency crate (does it break at compile time, in which case we'll easily detect and fix for future upgrades, or does it possibly introduce bugs, or would it still be expected to work)?
There was a problem hiding this comment.
That's a very good question that I spent some time figuring out the correct values. And here what I have so far
pub fn new(
url: impl AsRef<str>,
application_name: impl AsRef<str>,
sample_rate: u32,
spy_name: impl AsRef<str>,
spy_version: impl AsRef<str>,
backend: BackendImpl<BackendUninitialized>,
where spy_name and spy_version corresponds to the profiler running in current application. In Dataplane we are using pyroscope-rs and current create version of it is 1.0.1. I can't find any other doc related to this particular variable unfortunately.
There was a problem hiding this comment.
Pity we've got to update that number in addition to the version in Cargo.toml 😞 but not much we can do about it I guess. Thanks
3271fa8 to
e232393
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
name old req compatible latest new req ==== ======= ========== ====== ======= chrono 0.4.43 0.4.44 0.4.44 0.4.44 Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
name old req compatible latest new req ==== ======= ========== ====== ======= nix 0.31.1 0.31.2 0.31.2 0.31.2 Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
name old req compatible latest new req ==== ======= ========== ====== ======= pyroscope 0.5.8 0.5.8 1.0.1 1.0.1 [ Sergey: Address breaking change ] [ Quentin: Bump 1.0.1->1.0.2, comment to tell to keep versions in sync ] Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Sergey Matov <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
name old req compatible latest new req ==== ======= ========== ====== ======= rustls 0.23.36 0.23.37 0.23.37 0.23.37 Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
e232393 to
e56813c
Compare
|
@sergeymatov I forced-pushed on your branch:
|
|
@qmonnet thanks for adjustments and cleanup. Much appreciated |
🚀 Upgrades available