Skip to content

Do not run bundle-metadata.ts as part of npm run build#3884

Merged
mbg merged 1 commit intomainfrom
mbg/dev/no-build-metadata
May 7, 2026
Merged

Do not run bundle-metadata.ts as part of npm run build#3884
mbg merged 1 commit intomainfrom
mbg/dev/no-build-metadata

Conversation

@mbg
Copy link
Copy Markdown
Member

@mbg mbg commented May 7, 2026

Cherry-picked from #3808. We decided that we don't find the output from bundle-metadata.ts useful when running npm run build. This PR just removes the call. The script stays and can be run manually if desired.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from henrymercer May 7, 2026 14:40
@mbg mbg self-assigned this May 7, 2026
Copilot AI review requested due to automatic review settings May 7, 2026 14:40
@mbg mbg requested a review from a team as a code owner May 7, 2026 14:40
@github-actions github-actions Bot added the size/XS Should be very easy to review label May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the invocation of pr-checks/bundle-metadata.ts from the root npm run build script, keeping the script available for manual execution while simplifying the standard build path.

Changes:

  • Update the root build npm script to stop running npx tsx ./pr-checks/bundle-metadata.ts.
Show a summary per file
File Description
package.json Simplifies npm run build by removing the bundle-metadata.ts step while preserving the existing transpile + esbuild build steps.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@mbg mbg enabled auto-merge May 7, 2026 14:46
@mbg mbg added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit a16cb53 May 7, 2026
229 checks passed
@mbg mbg deleted the mbg/dev/no-build-metadata branch May 7, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants