Adjust alert location UntrustedCheckoutCritical#21800
Open
knewbury01 wants to merge 1 commit intogithub:mainfrom
Open
Adjust alert location UntrustedCheckoutCritical#21800knewbury01 wants to merge 1 commit intogithub:mainfrom
knewbury01 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the actions/untrusted-checkout/critical query so its main alert location points at the checkout step rather than the later poisonable step, bringing it closer to the related untrusted-checkout queries and documenting the resulting alert churn.
Changes:
- Changed the critical untrusted-checkout query selection to use the checkout step as the alert’s main location.
- Regenerated the expected test output to reflect the new alert locations.
- Added a change note explaining the location shift and the expected close/reopen behavior for existing alerts.
Show a summary per file
| File | Description |
|---|---|
actions/ql/src/Security/CWE-829/UntrustedCheckoutCritical.ql |
Adjusts the selected alert location in the critical query. |
actions/ql/test/query-tests/Security/CWE-829/UntrustedCheckoutCritical.expected |
Updates golden test output for the new alert locations. |
actions/ql/src/change-notes/2026-05-05-untrusted-checkout-high.md |
Adds a user-facing change note for the alert-location update. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
| --- | ||
| category: majorAnalysis | ||
| --- | ||
| * Adjusted `actions/untrusted-checkout/critical` to align more with other untrusted resource queries, where the alert location is the location where the artifact is obtained from (the checkout point). This aligns with the other 2 related queries. This will cause the same alerts to re-open for closed alerts of this query. No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change will result in alerts closing and reopening
but has the benefit of allowing the query main location to align better with other queries of this type