C++: Update test results after extractor changes#21853
Merged
Merged
Conversation
jketema
added
the
depends on internal PR
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates C++ dataflow taint test expectations to match extractor output changes.
Changes:
- Adds two expected local taint-flow result rows involving
noexcept(...)instl.h.
Show a summary per file
| File | Description |
|---|---|
cpp/ql/test/library-tests/dataflow/taint-tests/localTaint.expected |
Updates expected output for the local taint library test. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
geoffw0
reviewed
May 15, 2026
| | stl.h:96:42:96:42 | ref arg x | stl.h:95:69:95:69 | x | | | ||
| | stl.h:96:42:96:42 | ref arg x | stl.h:95:69:95:69 | x | | | ||
| | stl.h:292:30:292:40 | 0 | file://:0:0:0:0 | noexcept(...) | TAINT | | ||
| | stl.h:292:30:292:40 | 0 | file://:0:0:0:0 | noexcept(...) | TAINT | |
Contributor
There was a problem hiding this comment.
What does this flow represent - in particular where does the 0 come from? Line 292 is:
vector() noexcept(noexcept(Allocator())) : vector(Allocator()) { }
Contributor
Author
There was a problem hiding this comment.
Nothing. This code is never executed. I'd say this is a bug in the old dataflow library.
Contributor
There was a problem hiding this comment.
Ah, this is just a case where the extractor is extracting more (or something like that) and exposing existing issues.
geoffw0
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.