Skip to content

Unified: add default_queries and standard qls files and a dummy query#22083

Merged
asgerf merged 3 commits into
github:mainfrom
asgerf:unified/suites
Jun 30, 2026
Merged

Unified: add default_queries and standard qls files and a dummy query#22083
asgerf merged 3 commits into
github:mainfrom
asgerf:unified/suites

Conversation

@asgerf

@asgerf asgerf commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Needed to make DCA work

@asgerf asgerf requested a review from a team as a code owner June 29, 2026 10:11
Copilot AI review requested due to automatic review settings June 29, 2026 10:11
@asgerf asgerf added the no-change-note-required This PR does not need a change note label Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the standard CodeQL suite entrypoints and a default_queries setting for the Unified extractor so it can be used by downstream tooling (notably DCA) in the same way as other language extractors.

Changes:

  • Add default_queries: [codeql/unified-queries] to unified/codeql-extractor.yml.
  • Introduce standard suite files under unified/ql/src/codeql-suites/ (code scanning, security, and quality variants).
  • Wire those suites to codeql/suite-helpers selector files via apply.
Show a summary per file
File Description
unified/ql/src/codeql-suites/unified-security-extended.qls Adds unified “security-extended” suite using suite-helper selectors.
unified/ql/src/codeql-suites/unified-security-experimental.qls Adds unified “security-experimental” suite using suite-helper selectors.
unified/ql/src/codeql-suites/unified-security-and-quality.qls Adds unified “security-and-quality” suite using suite-helper selectors.
unified/ql/src/codeql-suites/unified-code-scanning.qls Adds unified “code-scanning” suite using suite-helper selectors.
unified/ql/src/codeql-suites/unified-code-quality.qls Adds unified “code-quality” suite using suite-helper selectors.
unified/ql/src/codeql-suites/unified-code-quality-extended.qls Adds unified “code-quality-extended” suite using suite-helper selectors.
unified/codeql-extractor.yml Sets the extractor’s default query pack to codeql/unified-queries.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 4
  • Review effort level: Low

Comment thread unified/ql/src/codeql-suites/unified-code-scanning.qls Outdated
Comment thread unified/ql/src/codeql-suites/unified-security-extended.qls Outdated
Comment thread unified/ql/src/codeql-suites/unified-security-experimental.qls Outdated
Comment thread unified/ql/src/codeql-suites/unified-security-and-quality.qls
asgerf added 2 commits June 30, 2026 12:34
The suites include 'Unified' in their name. It sounds a bit off but
it might cause confusion if we don't include some kind of language name
in there.
@asgerf asgerf force-pushed the unified/suites branch 2 times, most recently from 63cbf5e to 6b685cb Compare June 30, 2026 12:22
Comment thread unified/ql/src/DummyQuery.ql Fixed
@asgerf asgerf marked this pull request as draft June 30, 2026 12:30
@asgerf asgerf changed the title Unified: add default_queries and standard qls files Unified: add default_queries and standard qls files and a dummy query Jun 30, 2026
This is just to test DCA
@asgerf asgerf marked this pull request as ready for review June 30, 2026 13:28
@asgerf asgerf merged commit 8a46f03 into github:main Jun 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants