Update @github/copilot to 1.0.67#1860
Conversation
- Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s pinned @github/copilot dependency to 1.0.67 and refreshes generated RPC/types across SDKs to match the updated schema (notably adding GitHub-shaped telemetry forwarding types/handlers and a new CopilotUserResponse.te flag).
Changes:
- Bumped
@github/copilotto^1.0.67across Node/Java codegen/test-harness packages and lockfiles. - Regenerated SDK wire types for Node, Python, Go, Rust, and .NET, including new
gitHubTelemetry.eventclient-global handler shapes. - Updated Java’s reference implementation version property in
pom.xml.
Show a summary per file
| File | Description |
|---|---|
| test/harness/package.json | Bumps devDependency on @github/copilot to ^1.0.67. |
| test/harness/package-lock.json | Updates resolved @github/copilot tarballs/integrities to 1.0.67. |
| nodejs/package.json | Bumps Node SDK dependency on @github/copilot to ^1.0.67. |
| nodejs/package-lock.json | Updates resolved @github/copilot tarballs/integrities to 1.0.67. |
| nodejs/samples/package-lock.json | Updates samples lockfile to align with @github/copilot@^1.0.67. |
| nodejs/src/generated/rpc.ts | Regenerates TS RPC types; adds CopilotUserResponse.te and GitHub telemetry types/handler wiring. |
| python/copilot/generated/rpc.py | Regenerates Python RPC types; adds telemetry dataclasses + handler registration and CopilotUserResponse.te. |
| go/rpc/zrpc.go | Regenerates Go RPC types; adds telemetry structs/handler registration and CopilotUserResponse.Te. |
| rust/src/generated/api_types.rs | Regenerates Rust API types; adds telemetry structs and CopilotUserResponse.te. |
| dotnet/src/Generated/Rpc.cs | Regenerates .NET RPC types; adds telemetry types/handler interface + registration and CopilotUserResponse.Te. |
| java/scripts/codegen/package.json | Bumps Java codegen dependency on @github/copilot to ^1.0.67. |
| java/scripts/codegen/package-lock.json | Updates resolved @github/copilot tarballs/integrities to 1.0.67 for Java codegen. |
| java/pom.xml | Updates Java POM property tracking the reference implementation version to ^1.0.67. |
Review details
Files not reviewed (5)
- go/rpc/zrpc.go: Generated file
- java/scripts/codegen/package-lock.json: Generated file
- nodejs/package-lock.json: Generated file
- nodejs/samples/package-lock.json: Generated file
- test/harness/package-lock.json: Generated file
- Files reviewed: 4/13 changed files
- Comments generated: 1
- Review effort level: Low
This comment has been minimized.
This comment has been minimized.
Adapt hook E2E coverage to assert SDK callbacks are invoked now that the runtime accepts hook handlers. Include missing client-global RPC types generated from the updated schema. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Include experimental annotations emitted by the Go code generator for newly generated RPC types so generated-file verification stays clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Use Path.replace in the E2E provider so Windows can overwrite existing workspace metadata files when the runtime renames temporary files into place. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Cross-SDK Consistency ReviewThis PR is an automated update of The core new feature is ✅ SDKs with full
|
| SDK | Status |
|---|---|
| Node.js | Added in this PR (rpc.ts: GitHubTelemetryHandler, ClientGlobalApiHandlers.gitHubTelemetry) |
| Python | Already present (not modified in this PR) |
| Go | Added in this PR (zrpc.go: GitHubTelemetryHandler, ClientGlobalAPIHandlers.GitHubTelemetry) |
| .NET | Already present (not modified in this PR; Rpc.cs: IGitHubTelemetryHandler, ClientGlobalApiHandlers.GitHubTelemetry) |
⚠️ SDKs missing GitHubTelemetryHandler handler support
Java — The generated types (GitHubTelemetryClientInfo, GitHubTelemetryEvent, GitHubTelemetryNotification) are added in this PR, but there is no handwritten adapter (analogous to LlmInferenceAdapter) or user-facing API to handle incoming gitHubTelemetry.event requests. Without a handler, the runtime's telemetry forwarding events will be silently dropped for Java clients.
Rust — The generated types are already present in rust/src/generated/api_types.rs, but router.rs only routes llmInference.* client-global requests and has no path for gitHubTelemetry.event. Similarly, Rust's codegen script (scripts/codegen/rust.ts) doesn't generate client-global handler registration (unlike the TypeScript, Go, Python, and C# codegens). Telemetry events will be silently dropped.
Suggested follow-up
To complete feature parity:
- Java: Add a
GitHubTelemetryAdapter(similar toLlmInferenceAdapter) and expose a user-facing callback (e.g.,CopilotClientOptions.setOnGitHubTelemetryEvent) that registers thegitHubTelemetry.eventrequest handler. - Rust: Update
router.rs(and the Rust codegen script if a generated approach is preferred) to routegitHubTelemetry.eventrequests, and expose aGitHubTelemetryHandlertrait in the public API.
Neither gap is introduced by this PR — both pre-date it — but this PR makes them newly apparent because it brings the other four SDKs to full support. Tracking these as follow-up issues would help keep the SDKs consistent.
Generated by SDK Consistency Review Agent for issue #1860 · sonnet46 3.7M · ◷
Automated update of
@github/copilotto version1.0.67.Changes
@github/copilotinnodejs/package.jsonandtest/harness/package.jsonscripts/codegen)Java Handwritten Code Adaptation Plan
If
java-sdk-testsCI fails on this PR, follow these steps:mvn clean,mvn verifyfromjava/locally or check thejava-sdk-testsworkflow run logs.java/src/main/java/com/github/copilot/sdk/):nullfor optional new fields).CopilotSession.javaif applicable.java/src/test/java/com/github/copilot/sdk/):cd java && mvn clean test-compile jar:jar && mvn verify -Dskip.test.harness=truecd java && mvn spotless:applyNext steps
When ready, click Ready for review to trigger CI checks.