Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions data/reusables/actions/jobs/choosing-runner-overview.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
Use `jobs.<job_id>.runs-on` to define the type of machine to run the job on.

{% ifversion fpt or ghec %}- The destination machine can be either a [{% data variables.product.prodname_dotcom %}-hosted runner](#choosing-github-hosted-runners), [{% data variables.actions.hosted_runner %}](#choosing-runners-in-a-group), or a [self-hosted runner](#choosing-self-hosted-runners).{% else %}
* The destination machine can be a [self-hosted runner](#choosing-self-hosted-runners).{% endif %}
* The destination machine can be {% ifversion fpt or ghec %}either a [{% data variables.product.prodname_dotcom %}-hosted runner](#choosing-github-hosted-runners), [{% data variables.actions.hosted_runner %}](#choosing-runners-in-a-group), or a [self-hosted runner](#choosing-self-hosted-runners){% else %}a [self-hosted runner](#choosing-self-hosted-runners){% endif %}.
* You can target runners based on the labels assigned to them, or their group membership, or a combination of these.
* You can provide `runs-on` as:
* A single string
Expand Down
4 changes: 2 additions & 2 deletions eslint.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,11 @@ export default [
'src/dev-toc/**/*.{ts,js}',
'src/events/components/**/*.{ts,js}',
'src/fixtures/**/*.{ts,js}',
'src/github-apps/**/*.{ts,js}',
'src/journeys/**/*.{ts,js}',
'src/languages/**/*.{ts,js}',
'src/links/**/*.{ts,js}',
'src/metrics/**/*.{ts,js}',
'src/observability/lib/handle-package-not-found.ts',
'src/rest/**/*.{ts,js}',
'src/search/**/*.{ts,js}',
'src/shielding/**/*.{ts,js}',
],
Expand All @@ -203,6 +201,8 @@ export default [
'src/workflows/**/*.{ts,js}',
'src/content-linter/**/*.{ts,js}',
'**/*.{tsx,jsx}',
// CLI help script — chalk-colored terminal output, not application logging
'src/rest/docs.ts',
],
rules: {
'custom-rules/use-custom-logger': 'off',
Expand Down
9 changes: 3 additions & 6 deletions src/github-apps/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import fs from 'fs'
import type { GetServerSidePropsContext } from 'next'

import { readCompressedJsonFileFallback } from '@/frame/lib/read-json-file'
import { createLogger } from '@/observability/logger'
import { getOpenApiVersion } from '@/versions/lib/all-versions'
import { categoriesWithoutSubcategories } from '../../rest/lib/index'
import type { Context, ExtendedRequest } from '@/types'
Expand All @@ -15,7 +16,7 @@ interface AppsConfig {
// are expected to provide the concrete shape via the generic parameter.
type AppsData = Record<string, unknown>

const DEBUG = process.env.RUNNER_DEBUG === '1' || process.env.DEBUG === '1'
const logger = createLogger(import.meta.url)
const ENABLED_APPS_DIR = 'src/github-apps/data'
const githubAppsData = new Map<string, Map<string, AppsData>>()

Expand All @@ -33,11 +34,7 @@ export async function getAppsData<T extends AppsData = AppsData>(
docsVersion: string,
apiVersion?: string,
): Promise<T> {
if (DEBUG) {
console.log(
`[DEBUG] getAppsData: ROOT=${process.env.ROOT || '(not set)'}, path=${ENABLED_APPS_DIR}`,
)
}
logger.debug('getAppsData', { root: process.env.ROOT || '(not set)', path: ENABLED_APPS_DIR })

const pageTypeMap = githubAppsData.get(pageType)!
const filename = `${pageType}.json`
Expand Down
2 changes: 1 addition & 1 deletion src/journeys/components/JourneyTrackCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function JourneyTrackCard({ journey }: Props) {
{trackTitle}
</Link>
</h2>
<span className="f5 color-fg-muted">
<span role="status" className="f5 color-fg-muted">
{t('current_progress')
.replace('{n}', `${numberOfGuides}`)
.replace('{i}', `${currentGuideIndex + 1}`)}
Expand Down
Loading