Skip to content

fix: cherry-pick commit 8cf2cea to claude/create-sidecar-container-envoy#752

Closed
Claude wants to merge 1 commit intomainfrom
claude/add-commit-to-sidecar-container
Closed

fix: cherry-pick commit 8cf2cea to claude/create-sidecar-container-envoy#752
Claude wants to merge 1 commit intomainfrom
claude/add-commit-to-sidecar-container

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Feb 12, 2026

Cherry-picked commit 8cf2cea06a4da1c84fd11b5ac4205e66c97b3634 containing PR review fixes to the claude/create-sidecar-container-envoy branch.

Changes Applied

  • API proxy firewall exemption: Added proxyIp parameter to setupHostIptables() to allow unrestricted egress for the sidecar at 172.30.0.30
  • Envoy healthcheck: Changed from custom health endpoint (http://localhost:10000/) to Envoy admin endpoint (http://localhost:9901/ready)
  • Security hardening: Simplified cap_drop from selective capability list to ['ALL'] for maximum security
  • Test coverage: Added 19 unit tests covering API proxy service generation, environment injection, security hardening, and conditional behavior
  • Documentation: Updated comments and docs for host header rewriting and conditional BASE_URL environment variables

The cherry-pick resolved cleanly without conflicts, as the branch already contained the API proxy sidecar implementation being refined by these changes.

@Claude Claude AI assigned Claude and lpcox Feb 12, 2026
@Claude Claude AI changed the title [WIP] Add commit to sidecar container setup fix: cherry-pick commit 8cf2cea to claude/create-sidecar-container-envoy Feb 12, 2026
@Claude Claude AI requested a review from lpcox February 12, 2026 18:51
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

Bun Build Test Results

Project Install Tests Status
elysia 1/1 PASS
hono 1/1 PASS

Overall: PASS

All Bun projects installed successfully and all tests passed.

AI generated by Build Test Bun

@github-actions
Copy link
Contributor

Go Build Test Results

Project Download Tests Status
color 1/1 PASS
env 1/1 PASS
uuid 1/1 PASS

Overall: PASS

All Go projects built and tested successfully.

AI generated by Build Test Go

@github-actions
Copy link
Contributor

Build Test: Deno - PASSED ✅

Project Tests Status
oak 1/1 ✅ PASS
std 1/1 ✅ PASS

Overall: PASS

All Deno tests completed successfully.

AI generated by Build Test Deno

@github-actions
Copy link
Contributor

.NET Build Test Results

Project Restore Build Run Status
hello-world PASS
json-parse PASS

Overall: PASS

All .NET projects successfully restored, built, and ran with expected output.

AI generated by Build Test .NET

@github-actions
Copy link
Contributor

Node.js Build Test Results

Project Install Tests Status
clsx PASS ✅ PASS
execa PASS ✅ PASS
p-limit PASS ✅ PASS

Overall: ✅ PASS

All Node.js projects built and tested successfully.

AI generated by Build Test Node.js

@github-actions
Copy link
Contributor

Smoke Test Results - PASS ✅

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP
  • ✅ Playwright (github.com title verified)
  • ✅ File Writing
  • ✅ Bash Tool

cc: @Copilot @lpcox

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

Java Build Test Results

Project Compile Tests Status
gson 1/1 PASS
caffeine 1/1 PASS

Overall: PASS

All Java projects compiled successfully and all tests passed.

AI generated by Build Test Java

@github-actions
Copy link
Contributor

Smoke Test Results - Claude Engine

Last 2 Merged PRs:

  • fix: hide workDir from agent container to prevent secrets exposure
  • feat: hide /tmp/gh-aw/mcp-logs/ from agent containers

Test Results:
✅ GitHub MCP - Retrieved PRs successfully
✅ Playwright - Navigated to GitHub, verified title contains "GitHub"
✅ File Write - Created test file at /tmp/gh-aw/agent/smoke-test-claude-21959823980.txt
✅ Bash Tool - Verified file contents successfully

Overall Status: PASS

AI generated by Smoke Claude

@Mossaka
Copy link
Collaborator

Mossaka commented Feb 13, 2026

Closing PR in favor of tracking issue #839.

@Mossaka Mossaka closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants