fix: use secure temp directory in volume-mounts test by Mossaka · Pull Request #765 · github/gh-aw-firewall

Mossaka · 2026-02-12T20:13:52Z

Summary

Replace predictable /tmp/secret-file-12345.txt path with fs.mkdtempSync to create a unique temporary directory, preventing symlink attacks (CodeQL alert smoke test: copilot engine validation (run 20643921403) #173)
Write secret file with restrictive permissions (0o600) inside the secure temp directory
Update cleanup to recursively remove the temp directory instead of unlinking a single file

Test plan

npm run build compiles successfully
Integration tests pass (Test 4 still verifies container can't access host files outside custom mounts)

🤖 Generated with Claude Code

Replace predictable /tmp/secret-file-12345.txt path with fs.mkdtempSync to prevent symlink attacks (CodeQL alert #173). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-12T20:14:09Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-12T20:14:13Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-02-12T20:14:24Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-12T20:14:48Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	82.26%	82.42%	📈 +0.16%
Statements	82.31%	82.47%	📈 +0.16%
Functions	82.14%	82.14%	➡️ +0.00%
Branches	74.70%	74.80%	📈 +0.10%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/docker-manager.ts`	83.5% → 84.2% (+0.67%)	83.0% → 83.6% (+0.65%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

Pull request overview

This PR addresses CodeQL security alert #173 by replacing a predictable temporary file path with a secure temporary directory in the volume-mounts integration test. The change prevents potential symlink attacks by using fs.mkdtempSync to create a unique directory with restrictive permissions.

Changes:

Replaced hardcoded /tmp/secret-file-12345.txt path with fs.mkdtempSync for secure temp directory creation
Set restrictive file permissions (0o600) when writing the secret file
Updated cleanup logic to recursively remove the temporary directory instead of unlinking a single file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T20:16:06Z

tests/integration/volume-mounts.test.ts

    try {
      const result = await runner.runWithSudo(
-        'sh -c "cat /data/test.txt && cat /tmp/secret-file-12345.txt"',
+        `sh -c "cat /data/test.txt && cat ${secretFile}"`,


The secretFile path is directly interpolated into the shell command without proper escaping. If the path contains spaces or special characters (which is possible if os.tmpdir() returns such a path), the command will fail or could potentially be exploited. Consider using proper shell escaping or wrapping the path in quotes.

See below for a potential fix:

const escapedSecretFile = secretFile.replace(/'/g, `'\\''`); const result = await runner.runWithSudo( `sh -c "cat /data/test.txt && cat '${escapedSecretFile}'"`,

github-actions · 2026-02-12T20:17:49Z

Deno Build Test Results

Project	Tests	Status
oak	1/1	✅ PASS
std	1/1	✅ PASS

Overall: ✅ PASS

All Deno tests completed successfully.

AI generated by Build Test Deno

github-actions · 2026-02-12T20:17:49Z

Bun Build Test Results

Project	Install	Tests	Status
elysia	✅	1/1	PASS
hono	✅	1/1	PASS

Overall: PASS

All Bun projects built and tested successfully.

AI generated by Build Test Bun

github-actions · 2026-02-12T20:17:52Z

Build Test: C++ - PASS ✅

Project	CMake	Build	Status
fmt	✅	✅	PASS
json	✅	✅	PASS

Overall: PASS

All C++ projects built successfully.

AI generated by Build Test C++

github-actions · 2026-02-12T20:17:53Z

Smoke Test Results

Last 2 merged PRs:

fix: review recommendations for PR #720 #754: fix: review recommendations for PR feat: port one-shot-token from C to Rust and improve container security #720
fix: eliminate nested bash layer in chroot command execution for Java/.NET #715: fix: eliminate nested bash layer in chroot command execution for Java/.NET

✅ GitHub MCP: PASS
✅ Playwright: PASS (page title contains "GitHub")
✅ File Writing: PASS
✅ Bash Tool: PASS

Overall Status: PASS

AI generated by Smoke Claude

github-actions · 2026-02-12T20:17:57Z

Node.js Build Test Results

Project	Install	Tests	Status
clsx	✅	PASS	PASS
execa	✅	PASS	PASS
p-limit	✅	PASS	PASS

Overall: PASS ✅

All Node.js projects installed successfully and passed their tests.

AI generated by Build Test Node.js

github-actions · 2026-02-12T20:18:17Z

Go Build Test Results

Project	Download	Tests	Status
color	✅	1/1	PASS
env	✅	1/1	PASS
uuid	✅	1/1	PASS

Overall: PASS ✅

All Go projects built and tested successfully.

AI generated by Build Test Go

github-actions · 2026-02-12T20:18:18Z

Smoke Test Results (Run 21962630565)

Last 2 merged PRs:

fix: review recommendations for PR #720 #754: fix: review recommendations for PR feat: port one-shot-token from C to Rust and improve container security #720
fix: eliminate nested bash layer in chroot command execution for Java/.NET #715: fix: eliminate nested bash layer in chroot command execution for Java/.NET

✅ GitHub MCP - Last 2 PRs retrieved
✅ Playwright - Page title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub"
✅ File Writing - Created /tmp/gh-aw/agent/smoke-test-copilot-21962630565.txt
✅ Bash Tool - Verified file content

Status: PASS

cc: @Mossaka

AI generated by Smoke Copilot

github-actions · 2026-02-12T20:18:26Z

Smoke test results:
GitHub MCP merged PRs: fix: review recommendations for PR #720; fix: eliminate nested bash layer in chroot command execution for Java/.NET ✅
Safeinputs gh PR list: fix: replace unanchored regex with string assertions in tests; fix: eliminate TOCTOU race conditions in ssl-bump.ts ✅
Playwright GitHub title contains "GitHub" ✅
Tavily search "GitHub Agentic Workflows Firewall" ❌ (tool missing)
File write smoke-test-codex-21962630540.txt ✅
Bash cat verify ✅
Discussion query + comment ✅
Build npm ci && npm run build ✅
Overall: FAIL

AI generated by Smoke Codex

github-actions · 2026-02-12T20:18:31Z

Rust Build Test Results

Project	Build	Tests	Status
fd	✅	1/1	PASS
zoxide	✅	1/1	PASS

Overall: PASS ✅

All Rust projects built successfully and all tests passed.

AI generated by Build Test Rust

github-actions · 2026-02-12T20:18:48Z

.NET Build Test Results

Project	Restore	Build	Run	Status
hello-world	✅	✅	✅	PASS
json-parse	✅	✅	✅	PASS

Overall: PASS ✅

All .NET projects successfully restored, built, and ran with expected output.

AI generated by Build Test .NET

github-actions · 2026-02-12T20:18:59Z

Build Test: Java ✅

All Java projects successfully built and tested through AWF firewall.

Project	Compile	Tests	Status
gson	✅	1/1	PASS
caffeine	✅	1/1	PASS

Overall: PASS

Maven successfully downloaded dependencies through Squid proxy (172.30.0.10:3128) using configured ~/.m2/settings.xml.

AI generated by Build Test Java

fix: use secure temp directory in volume-mounts test

f1d82fb

Replace predictable /tmp/secret-file-12345.txt path with fs.mkdtempSync to prevent symlink attacks (CodeQL alert #173). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings February 12, 2026 20:13

Copilot started reviewing on behalf of Mossaka February 12, 2026 20:14 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

github-actions bot mentioned this pull request Feb 12, 2026

[agentics] No-Op Runs #735

Closed

github-actions bot added build-test-deno build-test-bun build-test-cpp labels Feb 12, 2026

github-actions bot added the smoke-claude label Feb 12, 2026

github-actions bot added build-test-node build-test-go labels Feb 12, 2026

github-actions bot added the smoke-copilot label Feb 12, 2026

github-actions bot added the build-test-rust label Feb 12, 2026

github-actions bot added the build-test-dotnet label Feb 12, 2026

github-actions bot added the build-test-java label Feb 12, 2026

Mossaka merged commit e94be9b into main Feb 12, 2026
91 checks passed

Mossaka deleted the fix/insecure-temp-file branch February 12, 2026 22:08

This was referenced Feb 12, 2026

fix: use granular workspace mounting instead of entire HOME directory #699

Merged

fix(docker): hide credentials at direct home mount in chroot mode #700

Merged

feat: add API proxy sidecar for secure LLM credential management #751

Merged

Conversation

Mossaka commented Feb 12, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 12, 2026

Deno Build Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

Bun Build Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

Build Test: C++ - PASS ✅

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Node.js Build Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

Go Build Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Rust Build Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

.NET Build Test Results

Uh oh!

github-actions bot commented Feb 12, 2026

Build Test: Java ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading