fix(ci): add network CIDR and localhost to NO_PROXY for api-proxy#822
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Claude
AI
changed the title
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
There was a problem hiding this comment.
Pull request overview
This PR fixes CI connectivity to the api-proxy sidecar by ensuring the agent container’s NO_PROXY/no_proxy includes all required bypass entries so tools (including CODEX) can reach 172.30.0.30 without being routed through Squid.
Changes:
- Expand the api-proxy
NO_PROXYvalue to include127.0.0.1,localhost, and172.30.0.0/16in addition toapi-proxyand the sidecar IP. - Update unit tests to assert the full
NO_PROXYcontent in both standalone and host-access scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/docker-manager.ts | Adds the complete api-proxy bypass list to NO_PROXY/no_proxy when the sidecar is enabled. |
| src/docker-manager.test.ts | Extends assertions to cover 127.0.0.1, localhost, and 172.30.0.0/16 for api-proxy scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Go Build Test Results
Overall: PASS ✅ All Go projects successfully compiled and passed tests.
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Overall Status: PASS cc:
|
C++ Build Test Results
Overall: PASS All C++ projects built successfully.
|
Bun Build Test Results
Overall: PASS ✅ All Bun projects successfully installed dependencies and passed their test suites.
|
.NET Build Test Results
Overall: PASS ✅ All .NET projects successfully restored, built, and ran within the firewall.
|
Node.js Build Test Results
Overall: PASS ✅ All Node.js projects successfully installed dependencies and passed their test suites.
|
Deno Build Test Results
Overall: ✅ PASS All Deno tests completed successfully.
|
Rust Build Test Results
Overall: PASS ✅ All Rust projects built successfully and passed their test suites.
|
Java Build Test Results ✅All Java projects successfully compiled and tested through the AWF firewall.
Overall: PASS Maven proxy configuration (using IP
|
Chroot Version Comparison Test Results
Overall Result: ❌ Tests did not pass - version mismatches detected for Python and Node.js
|
lpcox
merged commit 91c9df5
into
claude/enable-api-proxy-by-default
2 participants
The smoke-codex workflow was failing because CODEX couldn't reach the api-proxy sidecar at
172.30.0.30. TheNO_PROXYconfiguration was incomplete.Changes
Updated NO_PROXY for api-proxy (
src/docker-manager.ts:969)127.0.0.1,localhost, and network CIDR172.30.0.0/16api-proxy,172.30.0.30127.0.0.1,localhost,172.30.0.30,172.30.0.0/16,api-proxyUpdated tests (
src/docker-manager.test.ts)127.0.0.1,localhost, and172.30.0.0/16Context
Tools like CODEX require the network CIDR range in
NO_PROXYto bypass Squid and connect directly to the api-proxy sidecar. Without the complete set of bypass entries, requests fail to reach the sidecar on ports 10000/10001.