Conversation
5 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f705e8e3-b46a-4e44-8e76-386f499e9692 Co-authored-by: pelikhan <[email protected]>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f705e8e3-b46a-4e44-8e76-386f499e9692 Co-authored-by: pelikhan <[email protected]>
Copilot
AI
changed the title
[WIP] Fix specification audit issues found on 2026-04-15
Close specification coverage gaps for actionpins/stats and sync README APIs for workflow/parser/cli
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing package specifications and synchronizes several package READMEs so their documented public APIs match the current exported Go code (per the spec audit).
Changes:
- Added missing package specs for
pkg/actionpinsandpkg/stats. - Updated
pkg/workflowdocs to include the Gemini engine in the overview and public API tables. - Updated
pkg/parserandpkg/clidocs to include newly exported helper/command functions.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/README.md | Documents Gemini as a supported workflow engine and adds it to the engine API tables. |
| pkg/stats/README.md | New package spec documenting StatVar and its exported methods/behavior. |
| pkg/parser/README.md | Adds missing exported helper functions (virtual FS, tools merge, workflow frontmatter update) to the public API table. |
| pkg/cli/README.md | Documents exported action-related CLI command functions. |
| pkg/actionpins/README.md | New package spec documenting action pin resolution types/functions and thread-safety notes. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 3
Comment on lines
+27
to
+30
| | `Variance` | `func() float64` | Returns population variance (`N` denominator) | | ||
| | `SampleVariance` | `func() float64` | Returns sample variance (`N-1` denominator) | | ||
| | `StdDev` | `func() float64` | Returns population standard deviation | | ||
| | `SampleStdDev` | `func() float64` | Returns sample standard deviation | |
|
|
||
| | Function | Signature | Description | | ||
| |----------|-----------|-------------| | ||
| | `RegisterBuiltinVirtualFile` | `func(path string, content []byte)` | Registers embedded virtual file content under an `@builtin:` path | |
Comment on lines
+156
to
+157
| | `GetBuiltinFrontmatterCache` | `func(path string) (*FrontmatterResult, bool)` | Gets cached frontmatter parse results for built-in virtual files | | ||
| | `SetBuiltinFrontmatterCache` | `func(path string, result *FrontmatterResult) *FrontmatterResult` | Stores a frontmatter parse result in the built-in cache | |
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package specification audit reported two missing package READMEs and API drift in three existing package specs. This PR fills the missing specs and aligns exported API documentation with current code.
Add missing package specifications
pkg/actionpins/README.mdwith package overview, public types/functions, dependencies, and thread-safety notes.pkg/stats/README.mddocumentingStatVarbehavior and all exported methods.Sync workflow engine docs with current API
pkg/workflow/README.mdto include Gemini in engine overview/registry.GeminiEngineandNewGeminiEngine()to public API tables.Sync parser docs with newly exported helpers
pkg/parser/README.mdwith the 9 missing exported functions from:virtual_fs.gotools_merger.goworkflow_update.goSync CLI docs with exported action command functions
pkg/cli/README.mdto document:ActionsBuildCommandActionsValidateCommandActionsCleanCommandGenerateActionMetadataCommand