Skip to content

Fix AWF tool-cache mount quoting that broke Copilot startup in Daily Issues Report#39089

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/daily-issues-report-debug
Closed

Fix AWF tool-cache mount quoting that broke Copilot startup in Daily Issues Report#39089
Copilot wants to merge 3 commits into
mainfrom
copilot/daily-issues-report-debug

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The Daily Issues Report workflow failed because the Copilot engine exited before producing output. In the failing run, AWF launched without a usable Node runtime in chroot due to malformed tool-cache mount argument expansion.

  • Root cause

    • BuildAWFCommand emitted the optional mount as:
      • ${GH_AW_TOOL_CACHE_MOUNT:+--mount "$GH_AW_TOOL_CACHE_MOUNT"}
    • The inner quoting caused incorrect shell tokenization for --mount, so non-/opt tool-cache mounts were not applied reliably and Node was not visible inside AWF chroot.
  • Code changes

    • Updated AWF mount arg expansion to remove nested quotes and preserve correct argument splitting:
      • ${GH_AW_TOOL_CACHE_MOUNT:+--mount $GH_AW_TOOL_CACHE_MOUNT}
    • Updated the corresponding assertion in AWF command-generation tests.
  • Coverage updates

    • Added a focused shell-level test to assert expansion produces two args (--mount, <src>:<dst>:ro) without literal quote artifacts.
    • Regenerated affected workflow wasm golden files to reflect the command template change.
// before
toolCacheMountRef := fmt.Sprintf("${%s:+--mount \"$%s\"}", awfToolCacheMountVarName, awfToolCacheMountVarName)

// after
toolCacheMountRef := fmt.Sprintf("${%s:+--mount $%s}", awfToolCacheMountVarName, awfToolCacheMountVarName)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug daily issues report generator failure Fix AWF tool-cache mount quoting that broke Copilot startup in Daily Issues Report Jun 13, 2026
Copilot AI requested a review from pelikhan June 13, 2026 15:37
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot run pr-finisher skill

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot run pr-finisher skill

Completed a PR-finisher pass. No additional code changes were needed. Local validation passed (make fmt, make lint, make test-unit, make test, make recompile), there are no unresolved in-scope review threads, and prior CI failures in this PR context are action-required/stale snapshots. CI on the latest agent head still needs a human re-trigger before merge.

@pelikhan

Copy link
Copy Markdown
Collaborator

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan

Copy link
Copy Markdown
Collaborator

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix https://github.com/github/gh-aw/actions/runs/27472163434/job/81204970545#step:42:1

Fixed in 4c9af68. I updated the generated lock workflows so the AWF invocation now uses ${GH_AW_TOOL_CACHE_MOUNT:+--mount $GH_AW_TOOL_CACHE_MOUNT} (no nested quotes), which addresses the failing step 42 command in that run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants