Fix AIC usage cache always empty in activation job#39130
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Root cause: GitHub Actions actions/cache is branch-scoped. The Matt Pocock Skills Reviewer triggers on pull_request events, each on a unique PR branch, so caches saved by the conclusion job on branch A are never visible to the activation job on branch B. Fix: - Add aic-usage-cache artifact upload in conclusion job (cross-branch accessible) - Add artifact-based fallback step in activation job that downloads the most recent aic-usage-cache artifact when actions/cache/restore has a miss - New restore_aic_usage_cache_fallback.cjs script implements the fallback - Update WASM golden files and add unit tests Fixes #39050 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the “daily AIC usage cache always empty” behavior in activation jobs by adding an artifact-based fallback path to share the cached JSONL across branches (since actions/cache is branch-scoped for PR workflows).
Changes:
- Upload the AIC usage cache JSONL as a short-lived artifact (
aic-usage-cache) from the conclusion job. - Add an activation-job fallback step that downloads the most recent
aic-usage-cacheartifact when the cache file wasn’t restored fromactions/cache. - Update compiler tests and golden/lock workflow fixtures to include the new steps.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/restore_aic_usage_cache_fallback.cjs | New GitHub-script helper that restores the usage cache JSONL via artifact download when the cache file is missing. |
| actions/setup/js/restore_aic_usage_cache_fallback.test.cjs | Adds unit tests for the new artifact fallback script. |
| pkg/workflow/compiler_activation_job_builder.go | Emits a new activation step to run the artifact fallback after the cache restore step. |
| pkg/workflow/notify_comment.go | Emits a new conclusion step to upload the cache JSONL as an artifact after saving it to actions/cache. |
| pkg/workflow/daily_aic_workflow_guardrail_test.go | Extends tests to assert the new activation fallback + conclusion artifact upload steps exist in compiled output. |
| pkg/workflow/testdata//.golden | Updates golden workflow fixtures to include the new activation fallback step. |
| .github/workflows/*.lock.yml | Regenerates locked workflows to include the new activation fallback step and conclusion artifact upload step. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 259/259 changed files
- Comments generated: 1
| }, | ||
| }); | ||
|
|
||
| const cacheArtifact = artifacts.find(a => a.name === AIC_USAGE_CACHE_ARTIFACT_NAME && !a.expired); |
| continue-on-error: true | ||
| uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0 | ||
| env: | ||
| GH_AW_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
@copilot this is not needed key already present
There was a problem hiding this comment.
Removed the redundant GH_AW_GITHUB_TOKEN env entry from the fallback step — actions/github-script already exposes its github-token as GITHUB_TOKEN, and the fallback script already falls back to process.env.GITHUB_TOKEN. Regenerated all lock files in commit 3f6e1c8.
The `actions/github-script` action already exposes its `github-token` as `GITHUB_TOKEN` env var. The fallback script already reads `process.env.GITHUB_TOKEN` as a fallback, so the explicit `GH_AW_GITHUB_TOKEN` env entry on the step was redundant. Regenerated all 246 lock files and updated golden test fixtures. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
|
|
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
💫 TO BE CONTINUED... Smoke Claude failed to deliver outputs! Our hero faces unexpected challenges... |
|
🚀 Smoke Pi MISSION COMPLETE! Pi delivered. 🥧 |
|
🚀 Smoke Antigravity MISSION COMPLETE! Antigravity has spoken. ✨ |
|
📰 BREAKING: Smoke Copilot - AOAI (Entra) is now investigating this pull request. Sources say the story is developing... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
📰 BREAKING: Smoke Copilot - AOAI (apikey) is now investigating this pull request. Sources say the story is developing... |
|
🚀 Smoke Antigravity MISSION COMPLETE! Antigravity has spoken. ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🚀 Smoke Pi MISSION COMPLETE! Pi delivered. 🥧 |
|
💫 TO BE CONTINUED... Smoke Claude failed to deliver outputs! Our hero faces unexpected challenges... |
|
|
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
📰 BREAKING: Smoke Copilot - AOAI (Entra) is now investigating this pull request. Sources say the story is developing... |
|
📰 BREAKING: Smoke Copilot - AOAI (apikey) is now investigating this pull request. Sources say the story is developing... |
|
Commit pushed:
|
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
|
@copilot merge main and recompile |
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment. Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
💥 Smoke Test: Claude — Run 27480363196Core #1-12: ✅ all passed Overall: PARTIAL (1 skipped, 0 failed) — Claude engine nominal! Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
💥 [THE END] — Illustrated by Smoke Claude · 64.9 AIC · ⌖ 9.07 AIC · ⊞ 8.1K
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
Smoke test review: Consider confirming the changeset summary clearly references the AIC usage cache fix. 💥
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "gh-aw": patch | |||
| --- | |||
There was a problem hiding this comment.
Smoke test review: Nice — ensure the patch level matches the scope of the cache-scoping fix. 👍
|
Fix AIC usage cache always empty in activation job Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
…sage-cache-issue # Conflicts: # .github/workflows/test-quality-sentinel.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done — merged main and recompiled all 246 workflows in commit |
|
@copilot review all comments and address the unresolved review feedback on
|
actions/cacheis branch-scoped: caches written by the conclusion job on one PR branch are invisible to the activation job running on a different PR branch. Workflows triggered bypull_request(e.g. Matt Pocock Skills Reviewer) always run on unique branches, so the cache restore step always misses and the guardrail re-downloads all usage artifacts from scratch on every run.Fix
Conclusion job — after
actions/cache/save, upload the JSONL file as an artifact namedaic-usage-cache(7-day retention). Artifacts are accessible cross-branch via the GitHub REST API.Activation job — after
actions/cache/restore, run a newrestore_aic_usage_cache_fallback.cjsstep that:aic-usage-cacheartifact from the most recent matching runFiles
actions/setup/js/restore_aic_usage_cache_fallback.cjs— new fallback scriptpkg/workflow/compiler_activation_job_builder.go— adds fallback step to activation jobpkg/workflow/notify_comment.go— adds artifact upload step to conclusion job✨ PR Review Safe Output Test - Run 27478319746
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.comSee Network Configuration for more information.
Fix AIC usage cache always empty in activation job
actions/cacheis branch-scoped: caches written by the conclusion job on one PR branch are invisible to the activation job running on a different PR branch. Workflows triggered bypull_request(e.g. Matt Pocock Skills Reviewer) always run on unique branches, so the cache restore step always misses and the guardrail re-downloads all usage artifacts from scratch on every run.Fix
Conclusion job — after
actions/cache/save, upload the JSONL file as an artifact namedaic-usage-cache(7-day retention). Artifacts are accessible cross-branch via the GitHub REST API.Activation job — after
actions/cache/restore, run a newrestore_aic_usage_cache_fallback.cjsstep that:aic-usage-cacheartifact from the most recent matching runFiles
actions/setup/js/restore_aic_usage_cache_fallback.cjs— new fallback scriptpkg/workflow/compiler_activation_job_builder.go— adds fallback step to activation jobpkg/workflow/notify_comment.go— adds artifact upload step to conclusion job✨ PR Review Safe Output Test - Run 27478319746
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.comSee Network Configuration for more information.
💥 [THE END] — Illustrated by Smoke Claude · 106.7 AIC · ⌖ 25.5 AIC · ⊞ 8.1K · ◷
Changeset
✨ PR Review Safe Output Test - Run 27480363196
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.comSee Network Configuration for more information.