Draft
Make threat-detect binary install step continue-on-error in warn mode#52400
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add retry-with-backoff to AWF/threat-detect binary installers
Make threat-detect binary install step continue-on-error in warn mode
Aug 13, 2026
Contributor
PR TriageCategory: chore | Risk: low | Priority: low | Score: 31/100 Score breakdown: impact 15/50, urgency 8/30, quality 8/20 CI: unknown (draft) Recommended action: CI hardening chore, still draft/blocked. Automated triage — run 52400
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GitHub Releases CDN blip caused the
evals/detectionjob installers for the AWF firewall and threat-detect binaries to fail across multiple PR-gate workflows within a 25-minute window. The threat-detect binary download already had retry-with-backoff (curl --retry 5 --retry-delay 10 --retry-max-time 180), but a hard failure after retries still marked the wholedetectionjob asfailure— even though the job's own logic (GH_AW_DETECTION_CONTINUE_ON_ERROR) already treats a missing threat-detect binary as non-fatal in warn mode.Compiler change
buildInstallThreatDetectStepnow takes*WorkflowDataand emitscontinue-on-error: true(or the configured expression) for the "Install threat-detect binary" step, reusing the same continue-on-error resolution already applied to the detection conclusion/analysis steps:This keeps the install step's failure semantics consistent with the job's existing tolerance policy: in warn mode a transient download failure no longer flips the job conclusion to
failure; in strict mode (continue-on-error: false) the step still fails the job as before.Test coverage
threat_detection_isolation_test.go: added an assertion inTestExternalDetectorPathverifying the install step carriescontinue-on-error: truein the default warn mode.Generated workflows
.lock.ymlfiles; 104 workflows usingfeatures: gh-aw-detection: truepick up the newcontinue-on-error: trueline on this step.