Skip to content

Add ifc label for issue_read tool#2457

Merged
gokhanarkan merged 6 commits into
mainfrom
gokhanarkan/fides-issue-read
May 13, 2026
Merged

Add ifc label for issue_read tool#2457
gokhanarkan merged 6 commits into
mainfrom
gokhanarkan/fides-issue-read

Conversation

@gokhanarkan
Copy link
Copy Markdown
Member

Emits an IFC SecurityLabel on the issue_read tool result when the InsidersMode flag is enabled, mirroring the pattern landed for get_me in #2432, list_issues in #2453, get_file_contents in #2454, and search_issues in #2456.

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389. One of the ingress tools listed in #1623's tool table.

Chained on #2456 (which is itself chained on #2454). Base is currently gokhanarkan/fides-search-issues because this PR reuses FetchRepoIsPrivate and FetchRepoCollaborators. GitHub will auto-retarget the base to main as the upstream PRs merge.

What this PR does

  • Wires _meta.ifc onto the issue_read CallToolResult when deps.GetFlags(ctx).InsidersMode is true. No behaviour change when the flag is off.
  • issue_read operates on a single issue in a single repository, so the label has the same per-repo semantics as list_issues: integrity always untrusted; public repos → PublicUntrusted; private repos → PrivateUntrusted(collaborators) with [owner] fallback if the collaborators lookup fails. ifc.LabelListIssues is reused directly — no new pkg/ifc constructor.
  • The IssueRead handler dispatches to four sub-functions (GetIssue, GetIssueComments, GetSubIssues, GetIssueLabels). The IFC label is attached at the dispatch site via a single attachIFC closure, so all four method= branches emit the label without modifying the underlying helpers.
  • Visibility-lookup failures cause the label to be omitted entirely (consistent with get_file_contents and search_issues) to avoid misclassifying the result.

Suggested follow-up (not in this PR)

After this lands, three handlers (get_file_contents, search_issues, issue_read) carry near-identical attachIFC closures (~25 lines each). A small follow-up PR could extract them into a single shared helper (e.g. AttachRepoIFC(ctx, deps, client, owner, repo, labelFn) in pkg/github/ifc_attach.go), saving ~60 lines and keeping the pattern consistent across tools. Intentionally not bundled here to keep this PR minimal and easy to review.

Tests

Test_IssueRead_IFC_InsidersMode in pkg/github/issues_test.go with 4 subtests:

  1. Insiders off → result.Meta == nil.
  2. Insiders on, public repo, method=getintegrity=untrusted, confidentiality=["public"].
  3. Insiders on, private repo, method=get_commentsuntrusted/collaborator list (proves the wrapper applies to non-get dispatch branches).
  4. Insiders on, visibility lookup fails (500) → no ifc meta.

get_labels (GraphQL) gets the same wrapper coverage but isn't separately tested for IFC — the wrapper sits outside the dispatch and is method-agnostic.

Validation

  • go test -race ./... — green.
  • gofmt -s clean; go vet ./... clean.
  • (./script/lint itself fails locally with a pre-existing golangci-lint Go-version mismatch unrelated to this change.)
  • No tool schema/annotation changes → no toolsnap or README regeneration needed.

@gokhanarkan gokhanarkan requested a review from a team as a code owner May 12, 2026 11:12
Copilot AI review requested due to automatic review settings May 12, 2026 11:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds best-effort IFC SecurityLabel metadata to the issue_read MCP tool output when InsidersMode is enabled, aligning issue_read with the existing IFC-labeling pattern used by other ingress tools in this codebase.

Changes:

  • Attach _meta.ifc to successful issue_read results behind InsidersMode, using per-repo visibility + collaborators to compute a LabelListIssues-semantics label.
  • Apply IFC attachment uniformly across all issue_read dispatch methods (get, get_comments, get_sub_issues, get_labels) via a single wrapper closure.
  • Add unit tests covering insiders on/off, public/private repo labeling, and “visibility lookup fails → omit label” behavior.
Show a summary per file
File Description
pkg/github/issues.go Wraps IssueRead dispatch returns with an attachIFC helper that lazily computes and attaches _meta.ifc in insiders mode.
pkg/github/issues_test.go Adds Test_IssueRead_IFC_InsidersMode to validate IFC metadata behavior for issue_read across key scenarios.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Emits an IFC SecurityLabel on the search_issues tool result when the
InsidersMode flag is enabled, mirroring the pattern landed for get_me
in #2432, list_issues in #2453, and get_file_contents in #2454.

Search results may span multiple repositories, so the label is the IFC
join of the per-repository labels:

  - Integrity is always untrusted (issues are user-authored).
  - If any matched repository is public, the joined readers are
    ["public"] (the public side dominates the lub).
  - Otherwise the joined readers are the intersection of the
    collaborator sets across all matched private repositories.
  - Empty result sets are labelled public-untrusted (no data leaked).

The shared searchHandler in search_utils.go gains an additive variadic
'searchOption' hook so SearchIssues can attach _meta.ifc without
duplicating the search call. SearchPullRequests is unaffected; it does
not pass any options.

If any per-repository visibility or collaborators lookup fails the label
is omitted entirely, consistent with get_file_contents, to avoid
misclassifying the result.

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.

Note: this PR is chained on #2454 (gokhanarkan/fides-get-file-contents)
because it depends on the FetchRepoIsPrivate and FetchRepoCollaborators
helpers introduced there. GitHub will retarget the base to main once
#2454 merges.
- LabelSearchIssues now returns (SecurityLabel, bool); the bool is
  false when len(repoVisibilities) != len(readerSets), so callers can
  omit the label rather than emit one computed from inconsistent
  inputs.
- searchIssuesIFCPostProcess no longer substitutes [owner] when the
  collaborators API returns an empty list. The substitution was
  inconsistent with the cross-repo intersection semantics: the owner
  could appear in another matched private repo's collaborator list and
  thereby widen the joined reader set incorrectly. Empty collaborator
  sets are now passed through unchanged.
- Add a subtest exercising the collaborators-failure branch (500 on
  /repos/{owner}/{repo}/collaborators), asserting the tool still
  succeeds and result.Meta["ifc"] is absent.
- Extend the LabelSearchIssues table tests with the slice-length
  mismatch case.

Addresses the three Copilot findings on #2456.
@gokhanarkan gokhanarkan force-pushed the gokhanarkan/fides-search-issues branch from 279a59b to 1df735c Compare May 12, 2026 15:04
@gokhanarkan gokhanarkan force-pushed the gokhanarkan/fides-issue-read branch from 6181edd to 5271c51 Compare May 12, 2026 15:04
gokhanarkan added a commit that referenced this pull request May 12, 2026
Emits an IFC SecurityLabel on the search_repositories tool result when
the InsidersMode flag is enabled, mirroring the pattern landed for
get_me, list_issues, get_file_contents, search_issues, and issue_read.

Per the spec in github/copilot-mcp-core#1623, the label is
PublicUntrusted() regardless of whether matched repositories are
private. Repository search is treated as a discovery surface: matched
repositories are by definition already accessible to the caller, so
the joined readers are universal. Integrity is untrusted because
repository names, descriptions, and topics are user-authored.

Implementation note: SearchRepositories has its own handler distinct
from the shared searchHandler used by SearchIssues, so the IFC attach
is wired inline at the success return rather than via the postProcess
hook added in #2456.

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.

Note: chained on #2457 (gokhanarkan/fides-issue-read), which is in
turn chained on #2456. GitHub will retarget the base to main once
those merge.
Address Joanna's review feedback on #2456: a reader of a multi-repo result
must be authorised to read every matched private repository, so the IFC
join is the meet (intersection over private repos) rather than the join.
Public matches contribute the universe set and drop out of the
intersection without shrinking it.

- LabelSearchIssues: collect only the private reader sets, then intersect.
  Empty result and all-public remain public-untrusted.
- TestLabelSearchIssues: flip the mixed public+private expectation and add
  a 'two private + one public' case to lock in the new semantics.
- Test_SearchIssues_IFC_InsidersMode: mixed subtest now expects the
  private repo's reader set instead of public.
Emits an IFC SecurityLabel on the issue_read tool result when the
InsidersMode flag is enabled, mirroring the pattern landed for get_me
in #2432, list_issues in #2453, get_file_contents in #2454, and
search_issues in #2456.

issue_read operates on a single issue in a single repository so the
label has the same per-repo semantics as list_issues; the helper
ifc.LabelListIssues is reused directly. Integrity is always untrusted
(issue contents, comments, and label descriptions are user-authored).
Public repos are labelled PublicUntrusted; private repos are labelled
PrivateUntrusted with the repository's collaborator logins, falling
back to [owner] when the collaborators lookup fails.

The IssueRead handler dispatches to four sub-functions (GetIssue,
GetIssueComments, GetSubIssues, GetIssueLabels). The IFC label is
attached at the dispatch site via a single attachIFC closure, so all
four method branches emit the label without changes to the underlying
helpers. Visibility-lookup failures cause the label to be omitted
entirely (consistent with get_file_contents and search_issues).

A future cleanup PR can extract attachIFC into a shared helper now that
get_file_contents, search_issues, and issue_read use near-identical
closures; intentionally not bundled here to keep the diff minimal.

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.

Note: chained on #2456 (gokhanarkan/fides-search-issues), which is in
turn chained on #2454. GitHub will retarget the base to main once those
merge.
Comment thread pkg/github/issues.go Outdated
@gokhanarkan gokhanarkan force-pushed the gokhanarkan/fides-issue-read branch from 5271c51 to 513d12b Compare May 13, 2026 12:15
gokhanarkan added a commit that referenced this pull request May 13, 2026
Emits an IFC SecurityLabel on the search_repositories tool result when
the InsidersMode flag is enabled, mirroring the pattern landed for
get_me, list_issues, get_file_contents, search_issues, and issue_read.

Per the spec in github/copilot-mcp-core#1623, the label is
PublicUntrusted() regardless of whether matched repositories are
private. Repository search is treated as a discovery surface: matched
repositories are by definition already accessible to the caller, so
the joined readers are universal. Integrity is untrusted because
repository names, descriptions, and topics are user-authored.

Implementation note: SearchRepositories has its own handler distinct
from the shared searchHandler used by SearchIssues, so the IFC attach
is wired inline at the success return rather than via the postProcess
hook added in #2456.

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.

Note: chained on #2457 (gokhanarkan/fides-issue-read), which is in
turn chained on #2456. GitHub will retarget the base to main once
those merge.
Address Joanna's review feedback on #2457: the dispatch switch returns
on exactly one branch, so attachIFC runs at most once per request. The
ifcLabelKnown / ifcIsPrivate / ifcReaders cache variables were never
reused across calls and only added complexity.

Inline the visibility and collaborators lookups directly into the
closure and drop the cache. Behaviour is identical; a follow-up can
add real per-request caching across handlers if needed.
gokhanarkan added a commit that referenced this pull request May 13, 2026
Emits an IFC SecurityLabel on the search_repositories tool result when
the InsidersMode flag is enabled, mirroring the pattern landed for
get_me, list_issues, get_file_contents, search_issues, and issue_read.

Per the spec in github/copilot-mcp-core#1623, the label is
PublicUntrusted() regardless of whether matched repositories are
private. Repository search is treated as a discovery surface: matched
repositories are by definition already accessible to the caller, so
the joined readers are universal. Integrity is untrusted because
repository names, descriptions, and topics are user-authored.

Implementation note: SearchRepositories has its own handler distinct
from the shared searchHandler used by SearchIssues, so the IFC attach
is wired inline at the success return rather than via the postProcess
hook added in #2456.

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.

Note: chained on #2457 (gokhanarkan/fides-issue-read), which is in
turn chained on #2456. GitHub will retarget the base to main once
those merge.
@gokhanarkan gokhanarkan requested a review from JoannaaKL May 13, 2026 12:23
Base automatically changed from gokhanarkan/fides-search-issues to main May 13, 2026 12:45
@gokhanarkan gokhanarkan merged commit 883f58d into main May 13, 2026
18 checks passed
@gokhanarkan gokhanarkan deleted the gokhanarkan/fides-issue-read branch May 13, 2026 12:48
gokhanarkan added a commit that referenced this pull request May 13, 2026
Emits an IFC SecurityLabel on the search_repositories tool result when
the InsidersMode flag is enabled, mirroring the pattern landed for
get_me (#2432), list_issues (#2453), get_file_contents (#2454),
search_issues (#2456), and issue_read (#2457).

Search results may span multiple repositories, so the join math
(integrity always untrusted; private wins by intersecting collaborator
sets across the matched private repos only) is shared with search_issues
via ifc.LabelSearchIssues. Visibility is read directly off the search
response's repo.Private field — no extra API call. Collaborators are
fetched only for private hits, and any failure causes the label to be
omitted entirely (consistent with search_issues / issue_read /
get_file_contents).

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.
gokhanarkan added a commit that referenced this pull request May 13, 2026
Emits an IFC SecurityLabel on the search_repositories tool result when
the InsidersMode flag is enabled, mirroring the pattern landed for
get_me (#2432), list_issues (#2453), get_file_contents (#2454),
search_issues (#2456), and issue_read (#2457).

Search results may span multiple repositories, so the join math
(integrity always untrusted; private wins by intersecting collaborator
sets across the matched private repos only) is shared with search_issues
via ifc.LabelSearchIssues. Visibility is read directly off the search
response's repo.Private field — no extra API call. Collaborators are
fetched only for private hits, and any failure causes the label to be
omitted entirely (consistent with search_issues / issue_read /
get_file_contents).

Refs github/copilot-mcp-core#1623, github/copilot-mcp-core#1389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants