Skip to content

build(deps): bump basic-ftp from 5.2.2 to removed in the npm_and_yarn group across 1 directory - #403

Merged
francinelucca merged 4 commits into
mainfrom
dependabot/npm_and_yarn/npm_and_yarn-e39e87700b
Nov 20, 2026
Merged

francinelucca merged 4 commits into
mainfrom
dependabot/npm_and_yarn/npm_and_yarn-e39e87700b

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR deliberately migrates the browser-test toolchain and development runtime; it is not just a transitive dependency removal.

  • Upgrade @web/test-runner from ^0.19.0 to ^1.0.1, @web/test-runner-playwright from ^0.11.0 to ^1.0.1, and @web/dev-server-esbuild from ^0.3.6 to ^2.0.1 together.
  • Standardize CI, publishing, and the devcontainer on Node.js 24 LTS to satisfy the upgraded toolchain's Node.js 22+ requirements. Update contributor setup instructions accordingly.
  • Use npm ci in CI for reproducible installs.
  • Refresh the lockfile. The transitive basic-ftp dependency disappears as a consequence of the toolchain upgrade. All package download URLs use the public npm registry.

Acceptance scope

The scope includes the upgraded Web Test Runner/dev-server stack and Playwright adapter, Node.js 24 development/build/publishing configuration, and preservation of existing browser-test behavior. No intentional changes to the custom element's runtime behavior or public API are included.

Validation

  • Build, TypeScript checks, and ESLint pass on Node.js 24.
  • All 664 Chromium tests pass with the upgraded runner stack.
  • After normalizing the lockfile URLs, a clean offline npm ci succeeds; package versions and integrity hashes are unchanged by URL normalization.
  • Verified that the Node.js 24 devcontainer image tag exists. A container build was not run because Docker is unavailable in this environment.
  • A fresh public-registry download could not be verified because registry.npmjs.org was unreachable from this environment.

@dependabot
dependabot Bot requested a review from a team as a code owner November 18, 2026 00:39
Copilot AI adaptive review requested due to automatic review settings November 18, 2026 00:39
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change still has unresolved scope and security issues: it upgrades the test runner beyond the stated removal while introducing locked vulnerable picomatch versions with no available patch.

2 open issues
What changed in this PR

This pull request removes the transitive basic-ftp dependency while upgrading the Web Test Runner toolchain and regenerating the npm lockfile.

Changes:

  • Upgrades @web/test-runner from 0.19.0 to 1.0.1.
  • Removes basic-ftp and related unused transitive dependencies.
  • Refreshes test-runner, browser, Rollup, and development-server dependencies.
File Description
package.json Updates the direct @web/test-runner development dependency.
package-lock.json Regenerates the dependency tree for the test-runner upgrade and removes basic-ftp and its associated transitive packages.

Review effort: Lite (adaptive)

Comment thread package.json Resolved
Comment thread package.json Resolved
@francinelucca

Copy link
Copy Markdown
Contributor

@copilot update bafic-ftp to v6.2.6 instead of updating test-runner

Copilot AI commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@copilot update bafic-ftp to v6.2.6 instead of updating test-runner

Updated the transitive basic-ftp resolution to 6.2.6 and restored @web/test-runner to 0.19.0. Committed as 3873ba4.

@francinelucca

Copy link
Copy Markdown
Contributor

@dependabot recreate

Bumps the npm_and_yarn group with 1 update in the / directory: [basic-ftp](https://github.com/patrickjuchli/basic-ftp).


Removes `basic-ftp`

---
updated-dependencies:
- dependency-name: basic-ftp
  dependency-version:
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/npm_and_yarn-e39e87700b branch from 3873ba4 to 420fd2a Compare November 19, 2026 02:58
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile contains unresolved Azure DevOps registry URLs that can break clean installs, and the dependency upgrades require Node.js 22+ while the devcontainer still uses Node 16.

1 open issue
2 resolved since last review

Review effort: Lite (adaptive)

Comment thread package.json Resolved
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The lockfile hard-codes 127 package tarballs to an unconfigured private feed, so clean npm ci installs may fail outside the generating environment until it is regenerated against the intended public registry.

No open issues 🎉

1 resolved since last review

Review effort: Lite (adaptive)

@dependabot @github

dependabot Bot commented on behalf of github Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@francinelucca francinelucca reopened this Nov 20, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The manifest changes broaden the PR from removing transitive basic-ftp to a Web Test Runner/dev-server migration requiring Node.js 22+ and altered browser-test behavior, so the description and acceptance scope must be updated or the work split.

1 open issue

Review effort: Lite (adaptive)

Comment thread package.json Resolved
@francinelucca
francinelucca merged commit ab54326 into main Nov 20, 2026
7 checks passed
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/npm_and_yarn-e39e87700b branch November 20, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants