Repository navigation
build(deps): bump basic-ftp from 5.2.2 to removed in the npm_and_yarn group across 1 directory - #403
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The change still has unresolved scope and security issues: it upgrades the test runner beyond the stated removal while introducing locked vulnerable picomatch versions with no available patch.
2 open issues
What changed in this PR
This pull request removes the transitive basic-ftp dependency while upgrading the Web Test Runner toolchain and regenerating the npm lockfile.
Changes:
- Upgrades
@web/test-runnerfrom 0.19.0 to 1.0.1. - Removes
basic-ftpand related unused transitive dependencies. - Refreshes test-runner, browser, Rollup, and development-server dependencies.
| File | Description |
|---|---|
| package.json | Updates the direct @web/test-runner development dependency. |
| package-lock.json | Regenerates the dependency tree for the test-runner upgrade and removes basic-ftp and its associated transitive packages. |
Review effort: Lite (adaptive)
|
@copilot update bafic-ftp to v6.2.6 instead of updating test-runner |
Updated the transitive |
|
@dependabot recreate |
Bumps the npm_and_yarn group with 1 update in the / directory: [basic-ftp](https://github.com/patrickjuchli/basic-ftp). Removes `basic-ftp` --- updated-dependencies: - dependency-name: basic-ftp dependency-version: dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
3873ba4 to
420fd2a
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile contains unresolved Azure DevOps registry URLs that can break clean installs, and the dependency upgrades require Node.js 22+ while the devcontainer still uses Node 16.
1 open issue
2 resolved since last review
Review effort: Lite (adaptive)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The lockfile hard-codes 127 package tarballs to an unconfigured private feed, so clean npm ci installs may fail outside the generating environment until it is regenerated against the intended public registry.
No open issues 🎉
1 resolved since last review
Review effort: Lite (adaptive)
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The manifest changes broaden the PR from removing transitive basic-ftp to a Web Test Runner/dev-server migration requiring Node.js 22+ and altered browser-test behavior, so the description and acceptance scope must be updated or the work split.
1 open issue
Review effort: Lite (adaptive)



Summary
This PR deliberately migrates the browser-test toolchain and development runtime; it is not just a transitive dependency removal.
@web/test-runnerfrom^0.19.0to^1.0.1,@web/test-runner-playwrightfrom^0.11.0to^1.0.1, and@web/dev-server-esbuildfrom^0.3.6to^2.0.1together.npm ciin CI for reproducible installs.basic-ftpdependency disappears as a consequence of the toolchain upgrade. All package download URLs use the public npm registry.Acceptance scope
The scope includes the upgraded Web Test Runner/dev-server stack and Playwright adapter, Node.js 24 development/build/publishing configuration, and preservation of existing browser-test behavior. No intentional changes to the custom element's runtime behavior or public API are included.
Validation
npm cisucceeds; package versions and integrity hashes are unchanged by URL normalization.registry.npmjs.orgwas unreachable from this environment.