Skip to content

Cancel superseded collaborator searches in Hub review #328

Backlog

Description

@arniebradfo

Follow-up to #322 and #318. When a reviewer types another letter, the browser ignores the old mention request, but Hub can keep fetching up to 20 pages of GitHub collaborators after the response is no longer needed. Several searches can overlap as someone types and share the same GitHub App rate limit.

Stop a search when its client disconnects, including in-progress provider requests and any remaining pages. Keep the lookup bounded and keep the existing repository access and save-time mention checks. Add a regression test that disconnects during a lookup and verifies GitHub is not asked for another page. Consider a verified exact-login lookup for eligible users beyond the bounded scan without increasing calls for every partial query.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions