Skip to content

TransferClientV2#1370

Merged
aaschaer merged 7 commits intomainfrom
aaron/transfer_v2
Mar 30, 2026
Merged

TransferClientV2#1370
aaschaer merged 7 commits intomainfrom
aaron/transfer_v2

Conversation

@aaschaer
Copy link
Copy Markdown
Contributor

@aaschaer aaschaer commented Feb 26, 2026

Adds TransferClientV2 to experimental, adds its supporting classes, and labels existing v2 support in the TransferClient as Beta as proposed here.

Most of the code in this PR is things for the existing TransferClient that were copied and then slightly modified to work with Transfer v2. Things that are completely new:

  • TransferClientV2.list_stream_access_points
  • IterableJSONAPIResponse
  • JSONAPIPaginator

Some things that aren't included here but would be nice to have at some point:

  • some kind of JSON:API document constructor class. This probably can be added without breaking anything as long as it is/acts like a dict.
  • better JSON:API support in responses. Not sure if this would be a separate class, or adding convenience attributes/methods to GlobusHTTPResponse that are available if the response looks like a JSON:API response

I also found some issues with the existing tunnels support in the TransferClient while copying things over to TransferClientV2, most notably the iteration on list_tunnels was looking for a v1 "DATA" key. I've included fixes for now, but I'm a bit worried about supporting those going forwards. We likely will make more changes and fixes TransferClientV2 side that might not make it to TransferClient, so maybe we should deprecate those completely rather than leaving them there with a "careful this is Beta" comment?

@aaschaer aaschaer changed the title TransferClientV2, more JSON:API support, and tunnels fixes TransferClientV2 Feb 26, 2026
@aaschaer aaschaer marked this pull request as ready for review March 3, 2026 22:27
@aaschaer
Copy link
Copy Markdown
Contributor Author

aaschaer commented Mar 3, 2026

Marking this ready for review as it now has tests and I think its enough to start adding Transfer v2 support to going forwards.

@aaschaer aaschaer force-pushed the aaron/transfer_v2 branch from ce097aa to 6a6c220 Compare March 27, 2026 21:00
@aaschaer aaschaer requested a review from sirosen March 27, 2026 21:00
Copy link
Copy Markdown
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes but I think we're quite close to having this finished. 🚀

aaschaer and others added 3 commits March 27, 2026 16:39
Co-authored-by: Stephen Rosen <sirosen@globus.org>
Co-authored-by: Stephen Rosen <sirosen@globus.org>
@aaschaer aaschaer requested a review from sirosen March 30, 2026 16:08
@aaschaer aaschaer merged commit b7144f0 into main Mar 30, 2026
7 checks passed
@aaschaer aaschaer deleted the aaron/transfer_v2 branch March 30, 2026 18:55
@sirosen sirosen mentioned this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants