Support defining C99 bool as the BOOL type#322
Open
dblsaiko wants to merge 2 commits intognustep:masterfrom
Open
Support defining C99 bool as the BOOL type#322dblsaiko wants to merge 2 commits intognustep:masterfrom
dblsaiko wants to merge 2 commits intognustep:masterfrom
Conversation
davidchisnall
approved these changes
Dec 18, 2024
dblsaiko
force-pushed
the
push-qzyozwqtqtlr
branch
from
e142629 to
7a13e68
Compare
davidchisnall
force-pushed
the
push-qzyozwqtqtlr
branch
from
7a13e68 to
ac0168e
Compare
dblsaiko
force-pushed
the
push-qzyozwqtqtlr
branch
from
ac0168e to
fda587d
Compare
Contributor
Author
|
I think this should actually check that __OBJC_BOOL_IS_BOOL is 1 and not just defined. Oops. Hopefully the Windows tests pass now. |
Whether to use C99 bool can be set at build time using -DOBJC_BOOL_IS_BOOL_MODE=auto/always/never. Default is to use C99 bool if __OBJC_BOOL_IS_BOOL is defined and set to 1, which is currently the case for Clang on newer Apple platforms. This matches the behavior of Apple's libobjc (especially when combined with STRICT_APPLE_COMPATIBILITY). (See https://www.jviotti.com/2024/01/05/is-objective-c-bool-a-boolean-type-it-depends.html for more information about the __OBJC_BOOL_IS_BOOL definition.)
dblsaiko
force-pushed
the
push-qzyozwqtqtlr
branch
from
fda587d to
cf1b308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether to use C99 bool can be set at build time using
-DOBJC_BOOL_IS_BOOL_MODE=auto/always/never.
Default is to use C99 bool if __OBJC_BOOL_IS_BOOL is defined and
set to 1, which is currently the case for Clang on newer Apple
platforms. This matches the behavior of Apple's libobjc (especially
when combined with STRICT_APPLE_COMPATIBILITY).
(See
https://www.jviotti.com/2024/01/05/is-objective-c-bool-a-boolean-type-it-depends.html
for more information about the __OBJC_BOOL_IS_BOOL definition.)
Note turning this on with GNUstep currently breaks Gorm files written with a different BOOL type just like gnustep/libs-gui#318. Potentially needs this gnustep/libs-gui#318 (comment) to be usable.