Support flag to clear outputs from config #6273
Draft
+521
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
timofurrer
force-pushed
the
clear-config-outputs-flag
branch
2 times, most recently
from
b9bcd1f to
271cea7
Compare
This change set adds a new command line flag called `--clear-config-outputs`. When setting this flag all configured outputs from the config file will be cleared and only the ones from the command line respected or if none, fallback to the default happens. This is useful for applications like the golangci-lint LSP that invoke golangci-lint and want to ensure that only the JSON output is enabled without respecting the users config.
timofurrer
force-pushed
the
clear-config-outputs-flag
branch
from
271cea7 to
0ead74b
Compare
ldez
added
area: config
Member
I would have preferred an issue, focused on the explanation of the problem, before opening a PR. I need to think about this more. For now, please don't change the PR content to avoid wasting time on this. |
Author
|
@ldez does it make sense open that issue then ... before I waste more time on this ? |
3 tasks
Author
|
Anyways, here we go: #6274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds a new command line flag called
--clear-config-outputs. When setting this flag all configured outputs from the config file will be cleared and only the ones from the command line respected or if none, fallback to the default happens.This is useful for applications like the golangci-lint LSP that invoke golangci-lint and want to ensure that only the JSON output is enabled without respecting the users config.