You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove beta warning and obsolete flag conversion for Cloud Run jobs #593
The beta warning and the --update-secrets flag conversion logic for Cloud Run jobs appear to no longer be necessary.
Background
Cloud Run jobs support was added in v2.4.0 (April 2024) with a beta warning. Since then, approximately 20 months have passed, and the following changes have occurred:
--update-secrets flag is now supported for gcloud run jobs deploy
The current code includes a comment stating: "There is no --update-secrets flag on jobs, but there will be in the future. At that point, we can remove this."
This flag is now available (verified with gcloud run jobs deploy --help)
Cloud Run jobs has become a stable, mature feature
Current behavior
The following warnings are displayed on every job deployment:
Support for Cloud Run jobs in this GitHub Action is in beta and is not covered by the semver backwards compatibility guarantee.
Cloud Run does not allow updating secrets on jobs, ignoring "secrets_update_strategy" value of "merge"
Proposed changes
Remove the beta warning (src/main.ts lines 171-174)
Remove the --update-secrets to --set-secrets conversion logic and associated warning (src/main.ts lines 192-201)
References
Related commit: 32334e9 (Add support for Cloud Run jobs)
Activity
Remove beta warning and obsolete flag conversion for Cloud Run jobs