-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(models): handle function_response in lite_llm payload check #4316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(models): handle function_response in lite_llm payload check #4316
Conversation
Fixes google#4249. Added support for function_response in _part_has_payload.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @dineshkrishna9999, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the LiteLLM integration, specifically when handling Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses the issue of function_response not being correctly identified as a payload in _part_has_payload, which was causing unintended fallback user messages and breaking tool calling flows. The addition of the if part.function_response: return True condition directly resolves the problem. The new unit tests in tests/unittests/models/test_litellm_function_response.py provide good coverage for this fix, ensuring the updated logic works as expected. The other changes are primarily stylistic and improve code readability without altering functionality.
|
@google-cla check |
|
Submitted with the latest changes Thank you, |
Link to Issue or Description of Change
Problem: When using LiteLLM with OpenAI/Azure models,
types.Partobjects containing only afunction_responsewere incorrectly treated as having no payload in_part_has_payload. This caused_append_fallback_user_content_if_missingto inject an unintended fallback user message, breaking the tool calling flow and potentially triggering content safety filters.Solution: Updated
_part_has_payloadinsrc/google/adk/models/lite_llm.pyto correctly identifyfunction_responseas a valid payload. This prevents the unnecessary injection of the fallback user message when a function response is present.Testing Plan
Unit Tests
tests/unittests/models/test_litellm_function_response.pySummary of pytest results:
Regression testing on full
lite_llmsuite:uv run pytest tests/unittests/models/test_litellm.py # ============================= 176 passed in 3.61s ==============================Manual End-to-End (E2E) Tests
part.function_responseis now correctly recognized as a payload../autoformat.sh.Checklist
Additional context