Skip to content

add composite index on events table#4836

Draft
TanishqPorwar wants to merge 1 commit intogoogle:mainfrom
TanishqPorwar:feat/add-events-composite-index
Draft

add composite index on events table#4836
TanishqPorwar wants to merge 1 commit intogoogle:mainfrom
TanishqPorwar:feat/add-events-composite-index

Conversation

@TanishqPorwar
Copy link

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

-Related: #4827

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
Events table lacks an index for the primary query pattern WHERE app_name=? AND user_id=? AND session_id=? ORDER BY timestamp DESC, causing full table scans on PostgreSQL

Solution:
Add a SQLAlchemy Index to the v1 schema model, which gets applied by create_all() on new databases

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@google-cla
Copy link

google-cla bot commented Mar 14, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot
Copy link
Collaborator

adk-bot commented Mar 14, 2026

Response from ADK Triaging Agent

Hello @TanishqPorwar, thank you for creating this PR!

To move forward with the review process, could you please address the following items from our contribution guidelines:

  • Sign our Contributor License Agreement (CLA): It appears the CLA has not been signed yet. You can sign it at https://cla.developers.google.com/.
  • Provide a Testing Plan: Could you please provide details on how you've tested these changes? This should include a summary of the unit tests and steps for manual end-to-end (E2E) testing.

This information will help reviewers to review your PR more efficiently. Thanks!

@adk-bot adk-bot added the services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc label Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants