This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Support configurable emulator screen resolution#225
Open
jnhyperion wants to merge 3 commits intogoogle:masterfrom
Open
Support configurable emulator screen resolution#225jnhyperion wants to merge 3 commits intogoogle:masterfrom
jnhyperion wants to merge 3 commits intogoogle:masterfrom
Conversation
pokowaka
suggested changes
Dec 22, 2020
Contributor
pokowaka
left a comment
There was a problem hiding this comment.
- Would you mind moving the UI pieces to emu_downloads_menu.py?
- Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.
Author
I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:
What do you think? |
Contributor
You are absolutely right. I should have prefixed it with would you like us to make those changes (different device profiles) |
Author
|
@pokowaka sure, it would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added emulator screen resolution configuration options in interactive mode.