Repository navigation
Fix ArrayRecord OSS build, macOS TensorFlow segfault, and GitHub CI. - #210
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_992591542
branch
5 times, most recently
from
October 5, 2026 19:26
62ddb02 to
355b20c
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_992591542
branch
2 times, most recently
from
October 5, 2026 20:04
0fe1037 to
3730026
Compare
PiperOrigin-RevId: 993856096
copybara-service
Bot
force-pushed
the
test_992591542
branch
from
October 5, 2026 20:06
3730026 to
88cba2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ArrayRecord OSS build, macOS TensorFlow segfault, and GitHub CI.
Importing
array_record_module.soalongside TensorFlow 2.21+ on macOS and Linux caused a segmentation fault (Segmentation fault: 11inoss/test_import_tensorflow.py) becausearray_record_module.sostatically linked C++ Protobuf 28.3 and Abseil with default global symbol visibility, colliding at runtime with TensorFlow'slibtensorflow_framework(Protobuf 31.1). In addition, the OSS Bazel build failed due to unpinnedprotobufdependencies inMODULE.bazel, newerabsl::MutexLockandMutex::try_lock/unlockAPIs in the C++ writers not yet available in the pinned OSSabseil-cpprelease, and unquoted version specifiers inoss/build_whl.sh.Restrict exported symbols of
array_record_module.soin OSS builds to onlyPyInit_array_record_modulevia-Wl,-exported_symbol,_PyInit_array_record_moduleon macOS and a linker version script (-Wl,--version-script) on Linux. Pinprotobufto 28.3 inMODULE.bazel, use Copybara replacements to rewriteabsl::MutexLockandtry_lock/unlockcalls in the C++ record writers for OSS Abseil compatibility while keeping the modern API internally, and fixoss/build_whl.shto quotetensorflow>=2.20.0, enforce--only-binary :all:for wheel test dependencies, and install the specific built wheel file.