Add 'yapf' style parameter to butler.py yapf calls #5125
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempting to use the obsolete 'chromium' style as the default.
mverde
requested review from
jonathanmetzman and
letitz
and removed request for
jonathanmetzman and
letitz
Collaborator
|
The CI failure makes me think you ran the formatting command while not in our virtualenv/using a different version of yapf. After installing our dependencies and doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using butler.py's format and lint commands it seems the default style config currently used for yapf calls is 'chromium', which has been renamed to 'yapf': https://github.com/google/yapf/blob/12005095296072751e3e4c1f33a047d41b0ce18d/CHANGELOG.md?plain=1#L168. This was giving me errors related to the 'chromium' style not being found.