Handle var in UnnecessaryBoxedVariable#5541
Closed
copybara-service[bot] wants to merge 0 commit intomasterfrom
Closed
Handle var in UnnecessaryBoxedVariable#5541copybara-service[bot] wants to merge 0 commit intomasterfrom
var in UnnecessaryBoxedVariable#5541copybara-service[bot] wants to merge 0 commit intomasterfrom
Conversation
4e3364a to
868e7f9
Compare
868e7f9 to
3d817b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle
varinUnnecessaryBoxedVariableAdd a helper for replacing local variable types that handles
var.Often we want to avoid replacing types of
varlocal variables, but in this case using an explicit unboxed type will avoid the unnecessary boxing, and usingvarfor primitive types seems low value.#5522