Clean up Vec and Box JNI helpers#558
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
copybara-service
bot
force-pushed
the
test_890478258
branch
3 times, most recently
from
ef51d9b to
5e233f6
Compare
Use overloads for different input types instead of repeating the input type in the parameter name. Add overloads for the new structs used in the Kotlin-native C-interface. Make the input parameters const reference where appropriate. Put output parameters at the end per C++ convention. Rename `UpdateJObjectInputOrThrow` to `UpdateJStrokeInputOrThrow`. The convention is to be clear in the function name what type the `jobject` parameter (or return type) is with `J` followed by the JVM class name (which in this case is `StrokeInput`). PiperOrigin-RevId: 890904172
copybara-service
bot
force-pushed
the
test_890478258
branch
from
5e233f6 to
78d8234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up Vec and Box JNI helpers
Use overloads for different input types instead of repeating the input type in the parameter name. Add overloads for the new structs used in the Kotlin-native C-interface.
Make the input parameters const reference where appropriate. Put output parameters at the end per C++ convention.
Rename
UpdateJObjectInputOrThrowtoUpdateJStrokeInputOrThrow. The convention is to be clear in the function name what type thejobjectparameter (or return type) is withJfollowed by the JVM class name (which in this case isStrokeInput).