build Python wheels with cibuildwheel and add to build workflow#406
build Python wheels with cibuildwheel and add to build workflow#406zacharyburnett wants to merge 3 commits intogoogle:masterfrom
cibuildwheel and add to build workflow#406Conversation
0d9a024 to
06d742f
Compare
cibuildwheelcibuildwheel and test with pytest
cibuildwheel and test with pytestcibuildwheel and test with pytest
|
The current blocking issue with building is that |
7408992 to
dceaa00
Compare
cibuildwheel and test with pytestscikit-build and add to build workflow with cibuildwheel
2cde677 to
d18b525
Compare
| find_package(PythonExtensions REQUIRED) | ||
| add_library(SwigBindings MODULE src/python) | ||
| python_extension_module(SwigBindings) | ||
| install(TARGETS SwigBindings LIBRARY DESTINATION s2geometry) |
There was a problem hiding this comment.
I'm not sure exactly what to put here; this just modifies the example from https://scikit-build.readthedocs.io/en/latest/usage.html#basic-usage
9a6d267 to
79a1be3
Compare
scikit-build and add to build workflow with cibuildwheelscikit-build and add to build workflow
ce3b399 to
344ea65
Compare
|
unfortunately, using |
713b7aa to
07817f3
Compare
2e641d4 to
e271937
Compare
scikit-build and add to build workflowcibuildwheel and add to build workflow
7d322e8 to
dfc5b91
Compare
|
building the Python 3.8 wheels for |
bf89cd8 to
ef63bf1
Compare
Since the error is in absl, this is an absl bug, although I think other places in S2 will have this problem. https://github.com/abseil/abseil-cpp#support Support for 10.13 will be dropped in the summer, so I wouldn't worry too much about this one. https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md#macos Why is this only a problem for this PR? We can add before |
ef63bf1 to
78d70e6
Compare
|
Progress! the repair wheel step now fails on macOS with |
af0e69e to
8ee519f
Compare
e81a1a6 to
d9e6506
Compare
d9e6506 to
5ed613b
Compare
|
It looks like skipping wheel delocation for macOS lets |
|
testing these wheels locally on macOS ARM, the tests at In order to publish to PyPI, @figroc just needs to configure the PyPI project https://pypi.org/project/s2geometry/ to add this repository ( |
|
I don't know if C++ SWIG can make use of the "Limited API / Stable ABI" (https://docs.cython.org/en/latest/src/userguide/limited_api.html) but if so, that would make it so that only a single wheel would have to be built and published, instead of having to build a wheel for each Python version. But that would probably require changes in |
closes #389,
blocked by #390[fixed]