add kubernetes deployment#160
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new "Production Kubernetes Deployment" guide and updates the documentation index and local testing guide to link to it. The reviewer feedback correctly points out that both the StatefulSet and Deployment YAML examples in the new guide are missing the required .spec.selector and template labels, which would cause validation failures in Kubernetes apps/v1.
| namespace: sam | ||
| spec: | ||
| serviceName: "sam-hub" | ||
| replicas: 3 | ||
| template: |
There was a problem hiding this comment.
The StatefulSet manifest is missing the required .spec.selector field and the corresponding .spec.template.metadata.labels. In Kubernetes apps/v1, a StatefulSet will fail to validate and deploy without these fields.
| namespace: sam | |
| spec: | |
| serviceName: "sam-hub" | |
| replicas: 3 | |
| template: | |
| spec: | |
| serviceName: "sam-hub" | |
| replicas: 3 | |
| selector: | |
| matchLabels: | |
| app: sam-hub | |
| template: | |
| metadata: | |
| labels: | |
| app: sam-hub | |
| spec: |
| spec: | ||
| replicas: 5 | ||
| template: | ||
| spec: |
There was a problem hiding this comment.
The Deployment manifest is missing the required .spec.selector field and the corresponding .spec.template.metadata.labels. In Kubernetes apps/v1, a Deployment will fail to validate and deploy without these fields.
| spec: | |
| replicas: 5 | |
| template: | |
| spec: | |
| spec: | |
| replicas: 5 | |
| selector: | |
| matchLabels: | |
| app: sam-node | |
| template: | |
| metadata: | |
| labels: | |
| app: sam-node | |
| spec: |
1 participant
No description provided.