[anneal][v2][exocrate] Add install fixup hook#3436
Open
mdittmer wants to merge 10 commits into
Open
Conversation
This was referenced Jun 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3 #3436 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
491140c to
a6368cf
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
ab47687 to
99917d8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
99917d8 to
ea1b487
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
a6368cf to
281a0b5
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
ea1b487 to
cf94e7c
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
281a0b5 to
29be691
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
cf94e7c to
e96d761
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
29be691 to
43e88ed
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
43e88ed to
f901699
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
e96d761 to
a31da76
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
a31da76 to
856fa5a
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
f901699 to
51078d8
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
d902718 to
ddbf207
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
81becbe to
a943b6b
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
ddbf207 to
fca6bd9
Compare
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
a943b6b to
9183ca7
Compare
gherrit-pr-id: Gidzrynm2d4gpg6tdthfg66sexvlcu4nt
TAG=agy gherrit-pr-id: Gisb7egnyltdoxlay3of6lmsjbtlok7ct
TAG=agy gherrit-pr-id: Gbbpbt76nsgp2ohpclea46vot5joxx7b5
TAG=agy gherrit-pr-id: Gjnh4bziqtksdvg43zzll4732lxlcuss3
…tifacts TAG=agy gherrit-pr-id: G2xsxxkfz5kle6aunmehujqcrly3rjr4f
… source code TAG=agy gherrit-pr-id: Gzq7escrh5c2qcrgidomnfaxbsi6xn7yu
gherrit-pr-id: G3ub4smvhm3rbp6d53jhwn3knjeaw7ugn
…egration tests gherrit-pr-id: Gnafivbpqcaatsvsxamgsjcudchscvaae
Notes about largely unreviewed generated change: - Last test assertion looks dubious. Should probably switch all LLBC test verifications to something that properly parses the LLBC and makes more precise assertions. - Integration and structure requires more thought. It seems that only the scanner "knows" about this behaviour; is it being being plumbed through cmdline args and through run_charon? - New test (and probably other tests) should have their setup procedures overhauled/simplified. In general, I would expect the test to create a fixture, and then be able to pass largely static data to `run_charon()`, but right now it's manually setting up locked roots, etc., etc. gherrit-pr-id: Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
Teach exocrate to run a one-time fixup after fresh archive extraction while preserving archive permission bits. The hook lets Anneal rewrite install-root placeholders in Lake trace files and restore the installed toolchain to read-only form before normal use. gherrit-pr-id: G4a5griqkxk56ry227bqqe3kfzp7s2dmz
joshlf
force-pushed
the
G4a5griqkxk56ry227bqqe3kfzp7s2dmz
branch
from
9183ca7 to
d4a774d
Compare
joshlf
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
from
fca6bd9 to
0c793be
Compare
mdittmer
force-pushed
the
Gxsjyiksx4pd6h5gzup7ensn4qtrxu6s3
branch
9 times, most recently
from
cee0ac0 to
c7a57ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach exocrate to run a one-time fixup after fresh archive extraction while preserving archive permission bits. The hook lets Anneal rewrite install-root placeholders in Lake trace files and restore the installed toolchain to read-only form before normal use.
Latest Update: v22 — Compare vs v21
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G4a5griqkxk56ry227bqqe3kfzp7s2dmz && git checkout -b pr-G4a5griqkxk56ry227bqqe3kfzp7s2dmz FETCH_HEADCheckout
git fetch origin refs/heads/G4a5griqkxk56ry227bqqe3kfzp7s2dmz && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G4a5griqkxk56ry227bqqe3kfzp7s2dmz && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.