[anneal] Remove v1 Lake cache symlinks#3450
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
2 times, most recently
from
d5161c3 to
d13276c
Compare
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
3 times, most recently
from
2c07e27 to
0985f2c
Compare
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
3 times, most recently
from
732cd0f to
e8a9861
Compare
This was referenced Jun 15, 2026
joshlf
approved these changes
Jun 16, 2026
joshlf
left a comment
joshlf
left a comment
Member
There was a problem hiding this comment.
Approved mod requested changes
Findings: lake --old helps but is not enough if archive inputs have fresh mtimes, and without a root manifest Lake reconfigures path dependencies and writes locks into read-only package config trees; Lake manifest path entries can be relative to the generated workspace. In response, v1 generated workspaces now require Aeneas directly from the installed archive, write a locked relative lake-manifest.json, stop copying Aeneas/packages and symlinking .lake/build, and the archive build primes config caches, rewrites upstream trace prefixes, and makes Lake inputs older than prebuilt artifacts. gherrit-pr-id: Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
from
e8a9861 to
f6aeb9b
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings: lake --old helps but is not enough if archive inputs have fresh mtimes, and without a root manifest Lake reconfigures path dependencies and writes locks into read-only package config trees; Lake manifest path entries can be relative to the generated workspace. In response, v1 generated workspaces now require Aeneas directly from the installed archive, write a locked relative lake-manifest.json, stop copying Aeneas/packages and symlinking .lake/build, and the archive build primes config caches, rewrites upstream trace prefixes, and makes Lake inputs older than prebuilt artifacts.
Latest Update: v19 — Compare vs v18
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi && git checkout -b pr-Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi FETCH_HEADCheckout
git fetch origin refs/heads/Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.