chore: update apache http transports to use default jdk certs #2616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for deprecating GoogleUtils.getCertificateTrustStore() see go/stop-keystore-api-java-client update Apache http transports to use default jdk certs, instead of bundled certs.
We no longer want to support the bundled certs. This PR updates apache http transports to pass a null cert to SSLContext which will automatically load the default certs for the jdk. See how TrustManagerFactory loads from jdk defaults in TrustStoreManager when no keystore is provided
Tested both updated apache transports with calls storage API.
PR with deprecation is [here] (#2613)