Skip to content

impl(bigtable): add DeadlineOption#16085

Open
scotthart wants to merge 3 commits intogoogleapis:mainfrom
scotthart:bigtable_deadline_api
Open

impl(bigtable): add DeadlineOption#16085
scotthart wants to merge 3 commits intogoogleapis:mainfrom
scotthart:bigtable_deadline_api

Conversation

@scotthart
Copy link
Copy Markdown
Member

@scotthart scotthart commented Apr 27, 2026

This PR adds the bigtable::DeadlineOption for specifying the deadline for a single attempt at an RPC. This new option is being introduced first in Bigtable but will eventually be expanded to apply to other services (#4926).

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Bigtable-specific MergeOptions function to handle a new DeadlineOption, which allows setting per-RPC attempt deadlines by wrapping GrpcSetupOption. The generator and Bigtable clients are updated to use this new logic. Feedback points out missing header includes in the new options.h and options.cc files. Additionally, there is a concern regarding performance inefficiencies caused by redundant nested lambda wrapping when options are merged at multiple levels.

Comment thread google/cloud/bigtable/options.h
Comment thread google/cloud/bigtable/options.cc
Comment thread google/cloud/bigtable/options.cc
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 96.06299% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.70%. Comparing base (1b9b3c1) to head (a91f29f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/bigtable/options_test.cc 95.50% 4 Missing ⚠️
google/cloud/bigtable/options.cc 95.83% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #16085    +/-   ##
========================================
  Coverage   92.70%   92.70%            
========================================
  Files        2351     2353     +2     
  Lines      217954   218068   +114     
========================================
+ Hits       202047   202167   +120     
+ Misses      15907    15901     -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart force-pushed the bigtable_deadline_api branch from 37eff08 to a91f29f Compare April 27, 2026 20:35
@scotthart scotthart changed the title Bigtable deadline api impl(bigtable): add DeadlineOption Apr 28, 2026
@scotthart scotthart marked this pull request as ready for review April 28, 2026 15:52
@scotthart scotthart requested a review from a team as a code owner April 28, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant