impl(bigtable): add DeadlineOption#16085
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a Bigtable-specific MergeOptions function to handle a new DeadlineOption, which allows setting per-RPC attempt deadlines by wrapping GrpcSetupOption. The generator and Bigtable clients are updated to use this new logic. Feedback points out missing header includes in the new options.h and options.cc files. Additionally, there is a concern regarding performance inefficiencies caused by redundant nested lambda wrapping when options are merged at multiple levels.
cdb690b to
37eff08
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16085 +/- ##
========================================
Coverage 92.70% 92.70%
========================================
Files 2351 2353 +2
Lines 217954 218068 +114
========================================
+ Hits 202047 202167 +120
+ Misses 15907 15901 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
37eff08 to
a91f29f
Compare
This PR adds the
bigtable::DeadlineOptionfor specifying the deadline for a single attempt at an RPC. This new option is being introduced first in Bigtable but will eventually be expanded to apply to other services (#4926).