feat(firestore): support array_agg(), array_agg_distinct(), first(), last()#16029
feat(firestore): support array_agg(), array_agg_distinct(), first(), last()#16029Linchin wants to merge 3 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firestore client library by introducing several new aggregation functions. These additions allow users to collect values into arrays, retrieve distinct values, and easily select the first or last elements within a dataset, thereby expanding the analytical capabilities of the query pipeline. The changes are thoroughly tested with both unit and system tests to ensure reliability. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for array_agg(), array_agg_distinct(), first(), and last() aggregation functions. The changes include updates to pipeline expressions and the addition of corresponding unit and system tests. My review found a couple of minor grammatical errors in the docstrings, for which I've provided suggestions. These comments do not conflict with any of the provided rules and are therefore kept as is.
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
…line_expressions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…line_expressions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
TODO: