Skip to content

feat: regenerate automl using generator v1.32.0#17143

Open
parthea wants to merge 4 commits into
mainfrom
testing-automl
Open

feat: regenerate automl using generator v1.32.0#17143
parthea wants to merge 4 commits into
mainfrom
testing-automl

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 14, 2026

Updates post processing to account for dropping support for Python 3.7, 3.8, 3.9 and impacts that has on using 3.10 for lower bounds testing.

Bumps google-auth to >=2.23.3 to prevent dependency resolution issue when used in sync with google-cloud-storage

Corrects a deficiency in the constraints template that did not capture all the necessary bounds from setup.py

Partially corrects #17153 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google-cloud-automl package to require Python 3.10 or higher, removing support for Python 3.9 and simplifying legacy compatibility code. Key changes include bumping dependency versions, fixing asynchronous method calls in clients and samples, and refining unit test assertions for REST parameters. Review feedback recommends adding Python 3.13 to the test matrix and package classifiers, and restoring the flag to treat documentation warnings as errors.

"3.9",
"3.10",
"3.11",
"3.12",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the project now supports Python >= 3.10 and includes conditional dependencies for Python 3.13, it is recommended to include "3.13" in the ALL_PYTHON list to ensure the package is explicitly tested against the latest stable Python version.

Suggested change
"3.12",
"3.12",
"3.13",
References
  1. When updating the minimum supported Python version, ensure that the project's metadata and testing configurations are updated to reflect the supported versions consistently.

@@ -391,7 +390,6 @@ def docs(session):
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run(
"sphinx-build",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The -W flag was removed from the sphinx-build command. This flag ensures that documentation warnings are treated as errors, which is a best practice for maintaining high-quality documentation and catching issues like broken links or malformed docstrings in CI. It is recommended to restore this flag.

Suggested change
"sphinx-build",
"sphinx-build",
"-W", # warnings as errors

"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The project now requires Python >= 3.10 and includes dependencies specifically for Python 3.13 and 3.14. To accurately reflect this support and ensure the package is marked as compatible with the latest stable Python version, please add the "Programming Language :: Python :: 3.13" classifier here.

Suggested change
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
References
  1. When updating the minimum supported Python version, ensure that the project's metadata in 'setup.py' is updated to reflect the supported versions in Trove classifiers.

@chalmerlowe chalmerlowe marked this pull request as ready for review May 15, 2026 15:41
@chalmerlowe chalmerlowe requested review from a team as code owners May 15, 2026 15:41
@chalmerlowe chalmerlowe changed the title [testing] for-testing-purposes-automl feat: regenerate automl using generator v1.32.0 May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant