Skip to content

test(bigtable): temporarily disable real-service system tests, keep emulated - #18148

Merged
parthea merged 1 commit into
googleapis:mainfrom
mutianf:disable-bigtable-system-default-test
Aug 19, 2026
Merged

test(bigtable): temporarily disable real-service system tests, keep emulated#18148
parthea merged 1 commit into
googleapis:mainfrom
mutianf:disable-bigtable-system-default-test

Conversation

@mutianf

@mutianf mutianf commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Temporarily disables the system_default (real Cloud Bigtable service) system-test parametrization for google-cloud-bigtable, leaving system_emulated running.

The system nox session previously ran both system_default and system_emulated. This drops system_default from the parametrize list so only the emulator-backed system tests run.

A TODO is left in noxfile.py to re-enable system_default once the real-service system tests are green again. The system_default function itself is left intact (still referenced from test_map), so re-enabling is a one-line revert.

Change

 @nox.parametrize(
     "test_type",
-    ["system_default", "system_emulated"],
+    # TODO: Re-enable "system_default" once the real-service system tests are
+    # green again. Only the emulated system tests run for now.
+    ["system_emulated"],
 )

See follow up issue #18162

…vert)

Change-Id: I8ecf412b548f5ded6002b34ca9e159d4119fc393
@mutianf
mutianf requested a review from a team as a code owner August 18, 2026 22:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the noxfile.py configuration for google-cloud-bigtable to temporarily disable the 'system_default' test type, running only 'system_emulated' tests until the real-service system tests are green again. I have no feedback to provide as there are no review comments.

@daniel-sanche

Copy link
Copy Markdown
Contributor

It looks like this PR added some clean-up code to the system tests, that isn't scoped to the emulator. So it is still failing the quota check

I'll have to look into these quota issues. But if you need to disable the system tests today, it looks like the emulator will have to be disabled too

@parthea
parthea enabled auto-merge (squash) August 19, 2026 14:47
@parthea
parthea merged commit 9ddca5e into googleapis:main Aug 19, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants