test(bigtable): temporarily disable real-service system tests, keep emulated - #18148
Merged
parthea merged 1 commit intoAug 19, 2026
Merged
Conversation
…vert) Change-Id: I8ecf412b548f5ded6002b34ca9e159d4119fc393
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the noxfile.py configuration for google-cloud-bigtable to temporarily disable the 'system_default' test type, running only 'system_emulated' tests until the real-service system tests are green again. I have no feedback to provide as there are no review comments.
Contributor
|
It looks like this PR added some clean-up code to the system tests, that isn't scoped to the emulator. So it is still failing the quota check I'll have to look into these quota issues. But if you need to disable the system tests today, it looks like the emulator will have to be disabled too |
parthea
approved these changes
Aug 19, 2026
parthea
enabled auto-merge (squash)
August 19, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily disables the
system_default(real Cloud Bigtable service) system-test parametrization forgoogle-cloud-bigtable, leavingsystem_emulatedrunning.The
systemnox session previously ran bothsystem_defaultandsystem_emulated. This dropssystem_defaultfrom the parametrize list so only the emulator-backed system tests run.A
TODOis left innoxfile.pyto re-enablesystem_defaultonce the real-service system tests are green again. Thesystem_defaultfunction itself is left intact (still referenced fromtest_map), so re-enabling is a one-line revert.Change
@nox.parametrize( "test_type", - ["system_default", "system_emulated"], + # TODO: Re-enable "system_default" once the real-service system tests are + # green again. Only the emulated system tests run for now. + ["system_emulated"], )See follow up issue #18162