Skip to content

chore: improve sharded CI merge base detection - #18174

Merged
hebaalazzeh merged 5 commits into
googleapis:mainfrom
daniel-sanche:improve_merge_base
Aug 21, 2026
Merged

chore: improve sharded CI merge base detection#18174
hebaalazzeh merged 5 commits into
googleapis:mainfrom
daniel-sanche:improve_merge_base

Conversation

@daniel-sanche

Copy link
Copy Markdown
Contributor

CI Jobs have logic to find the merge base, and compare changes against it to determine which packages have changed in the PR

Previously, it used a fetch-depth of 2, to avoid downloading the whole monorepo history. This could cause issues finding the base, which would trigger a full test run (see #18166)

This PR does a full fetch (fetch-depth: 0), but filters out blobs, so the clone and comparison is still fast

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a minor formatting change to the README.rst file in the google-auth-oauthlib package, adding an extra newline. There are no review comments, and therefore no feedback to provide.

@daniel-sanche daniel-sanche changed the title chore: update CI merge base detection [DRAFT] chore: improve sharded CI merge base detection Aug 19, 2026
@daniel-sanche daniel-sanche changed the title [DRAFT] chore: improve sharded CI merge base detection chore: improve sharded CI merge base detection Aug 21, 2026
@daniel-sanche daniel-sanche added the unit_test:all_packages debug label used to trigger unit tests against all packages in a PR label Aug 21, 2026
Removed unnecessary blank line in README.
@daniel-sanche
daniel-sanche marked this pull request as ready for review August 21, 2026 17:12
@daniel-sanche
daniel-sanche requested a review from a team as a code owner August 21, 2026 17:12

@hebaalazzeh hebaalazzeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hebaalazzeh
hebaalazzeh merged commit 199aabd into googleapis:main Aug 21, 2026
144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unit_test:all_packages debug label used to trigger unit tests against all packages in a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants