fix: add bucket ownership check to pipeline artifacts bucket#6612
Open
instantraaamen wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: add bucket ownership check to pipeline artifacts bucket#6612instantraaamen wants to merge 1 commit intogoogleapis:mainfrom
instantraaamen wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The staging bucket fix (googleapis#6574) added `_verify_bucket_ownership()` to prevent bucket squatting, but the pipeline artifacts bucket still uses a predictable name (`{project}-vertex-pipelines-{location}`) and does not verify ownership when the bucket already exists. This adds the same ownership check to `create_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#6574 added
_verify_bucket_ownership()to the staging bucket path instage_local_data_in_gcs()to prevent bucket squatting (CVE-2026-2473). The pipeline artifacts bucket in the same file was not covered by that fix.create_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist()still uses a predictable bucket name ({project}-vertex-pipelines-{location}) and, when the bucket already exists, uses it without verifying ownership. An attacker can pre-create this bucket in their own project and intercept pipeline outputs.This adds the same
_verify_bucket_ownership()check to the pipeline bucket path.Reproducer