Skip to content

fix: Safely parse bq:// URIs using removeprefix instead of lstrip #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrishi wants to merge 8 commits into
base: main
Choose a base branch
from
+7 −5
Open

fix: Safely parse bq:// URIs using removeprefix instead of lstrip #6771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca696fb
fix(feature_store): safely parse bq:// URIs using removeprefix
mrishi May 12, 2026
79a4b0a
Merge branch 'main' into fix-bq-uri-parsing
matthew29tang Jun 11, 2026
804ce2f
fix(offline_store): safely parse bq:// URIs using removeprefix
mrishi Jun 11, 2026
9bb798f
fix(offline_store): safely parse bq:// URIs using removeprefix
mrishi Jun 11, 2026
f7e9447
fix(aiplatform): safely parse bq:// URIs using removeprefix
mrishi Jun 12, 2026
e1ca45c
Merge branch 'main' into fix-bq-uri-parsing
matthew29tang Jun 12, 2026
8f7aa97
fix(ai_platform): Black check
mrishi Jun 18, 2026
c922bbb
Merge branch 'main' into fix-bq-uri-parsing
mrishi Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agentplatform/resources/preview/feature_store/offline_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def _feature_to_data_source(
bq_uri = feature_group._gca_resource.big_query.big_query_source.input_uri
assert bq_uri

fully_qualified_table = bq_uri.lstrip("bq://")
fully_qualified_table = bq_uri.removeprefix("bq://")
assert fully_qualified_table

query = (
Expand Down
7 changes: 4 additions & 3 deletions google/cloud/aiplatform/preview/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
from google.protobuf import struct_pb2
from google.protobuf import json_format


_MULTIMODAL_METADATA_SCHEMA_URI = (
"gs://google-cloud-aiplatform/schema/dataset/metadata/multimodal_1.0.0.yaml"
)
Expand Down Expand Up @@ -1122,7 +1121,9 @@ def to_bigframes(self) -> "bigframes.pandas.DataFrame": # type: ignore # noqa:
A BigFrames dataframe.
"""
bigframes = _try_import_bigframes()
return bigframes.pandas.read_gbq_table(self.bigquery_table.lstrip("bq://"))
return bigframes.pandas.read_gbq_table(
self.bigquery_table.removeprefix("bq://")
)

@classmethod
@base.optional_sync()
Expand Down Expand Up @@ -1409,7 +1410,7 @@ def assemble(
)
result = assemble_lro.result(timeout=None)
_LOGGER.log_action_completed_against_resource("data", "assembled", self)
table_id = result.bigquery_destination.lstrip("bq://")
table_id = result.bigquery_destination.removeprefix("bq://")
if load_dataframe:
session_options = bigframes.BigQueryOptions(
credentials=initializer.global_config.credentials,
Expand Down
3 changes: 2 additions & 1 deletion vertexai/resources/preview/feature_store/offline_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ def _feature_to_data_source(
bq_uri = feature_group._gca_resource.big_query.big_query_source.input_uri
assert bq_uri

fully_qualified_table = bq_uri.lstrip("bq://")
fully_qualified_table = bq_uri.removeprefix("bq://")

assert fully_qualified_table

query = (
Expand Down
Loading