Fix static analysis warnings for GOST_cipher_ctx_iv_length returning -1#525
Merged
chipitsine merged 1 commit intogost-engine:masterfrom Apr 18, 2026
Merged
Fix static analysis warnings for GOST_cipher_ctx_iv_length returning -1#525chipitsine merged 1 commit intogost-engine:masterfrom
chipitsine merged 1 commit intogost-engine:masterfrom
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a Coverity report about an increased number of issues caused by
GOST_cipher_ctx_iv_lengthreturning -1 on error (see #523 (comment)). This behavior was introduced in 4e6e331.While the implementation matches
EVP_CIPHER_CTX_iv_length, which it replaces, returning 0 on error is safer. An assertion is added in debug builds to catch such cases.