build(deps): Update to thiserror version 2#82
Merged
LegNeato merged 1 commit intographql-rust:masterfrom Jan 16, 2025
Merged
Conversation
Depencency `thiserror` has some breaking changes, but non of them seem to impact `graphql-parser`. `cargo semver-checks` reports no changes on the API.
Member
|
Does the new version increase the supported Rust version or is every supported version the same? |
Contributor
Author
|
I didn't mention the MSRV because this repo doesn't specify a MSRV :-) The MRSV of Do you want me to create a PR to set the MSRV of this repo to 1.61 as well? Does |
Member
|
I don't think there is a current policy 🤔. @tailhook may know. |
Member
|
But I think if both the v1 and v2 both bumped the msrv its probably ok to bump here as well. I'll wait a bit for @tailhook and merge if no response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depencency
thiserrorhas some breaking changes, but non of them seem to impactgraphql-parser.cargo semver-checksreports no changes on the API.