Skip to content

style: Remove unneeded return statement#86

Merged
LegNeato merged 1 commit intographql-rust:masterfrom
caspermeijn:needless_return
Jan 16, 2025
Merged

style: Remove unneeded return statement#86
LegNeato merged 1 commit intographql-rust:masterfrom
caspermeijn:needless_return

Conversation

@caspermeijn
Copy link
Contributor

This solves clippy warnings like this:

error: unneeded `return` statement
   --> src/common.rs:226:5
    |
226 |     return Ok(result);
    |     ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `-D clippy::needless-return` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
    |
226 -     return Ok(result);
226 +     Ok(result)
    |

This solves clippy warnings like this:
```
error: unneeded `return` statement
   --> src/common.rs:226:5
    |
226 |     return Ok(result);
    |     ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `-D clippy::needless-return` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
    |
226 -     return Ok(result);
226 +     Ok(result)
    |
```
@LegNeato LegNeato merged commit c933ace into graphql-rust:master Jan 16, 2025
3 checks passed
@caspermeijn caspermeijn deleted the needless_return branch February 3, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants