android-interop-testing: add AndroidX Test core and rules to androidTestImplementation#12718
Open
shivaspeaks wants to merge 3 commits intogrpc:masterfrom
Open
android-interop-testing: add AndroidX Test core and rules to androidTestImplementation#12718shivaspeaks wants to merge 3 commits intogrpc:masterfrom
shivaspeaks wants to merge 3 commits intogrpc:masterfrom
Conversation
kannanjgithub
approved these changes
Mar 19, 2026
AgraVator
approved these changes
Mar 19, 2026
Member
|
Please test this by running the tests using grpc-java/buildscripts/kokoro/android-interop.sh Lines 31 to 43 in 91e9491 |
Member
Are you sure? You're telling me that implementation is not part of androidTestImplementation deps? That seems unlikely. What seems more likely is there's a version skew problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change explicitly adds 'libraries.androidx.test.rules' and 'libraries.androidx.test.core' to the 'androidTestImplementation' configuration.
This alignment follows the pattern used in the 'binder' module to ensure that these testing components are correctly packaged in the Test APK. Previously, these dependencies were only declared in the 'implementation' block (Main APK), which triggered a "classpath split" issue. In that state, the test process was unable to resolve internal orchestration classes, leading to NoClassDefFoundError crashes.
Fixes #12703 (comment)