Add browserId in email submission form#15377
Merged
Conversation
ioannakok
force-pushed
the
send-browser-id-in-email-submission-form
branch
from
b374633 to
98d49dd
Compare
github-actions
bot
removed
the
run_chromatic
7 tasks
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
AshCorr
approved these changes
Feb 18, 2026
ioannakok
force-pushed
the
send-browser-id-in-email-submission-form
branch
from
98d49dd to
e445b3d
Compare
arelra
reviewed
Mar 3, 2026
arelra
approved these changes
Mar 3, 2026
arelra
reviewed
Mar 3, 2026
| @@ -0,0 +1,16 @@ | |||
| import { getCookie, isString } from '@guardian/libs'; | |||
| import { useEffect, useState } from 'react'; | |||
|
|
|||
Member
There was a problem hiding this comment.
Small thing - I'm not sure if 'metrics.ts' is an easily understandable name for the file that this function lives in.
Perhaps useBrowserId.ts as per other hooks?
Member
There was a problem hiding this comment.
This was a post-merge comment. Not to worry, I can do this.
Contributor
Author
There was a problem hiding this comment.
I will raise a PR immediately!
|
Seen on PROD (merged by @ioannakok 8 minutes and 55 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Sends browserId when user subscribes to one newsletter. This flow does not require email confirmation and can be triggered in:
Why?
Supporter Revenue have made a request to send them the user id, the newsletter id, the browser id, and the timestamp when a user subscribes to a newsletter. Browser id is the only info we don't have. See related PRs in identity and frontend:
/consent-signupendpoint in IDAPI frontend#28613Screenshots
BrowserId is undefined in CODE so we will have to merge this to see whether we actually send it.