Skip to content

Full screen functionality for self hosted videos#15427

Open
abeddow91 wants to merge 9 commits intomainfrom
ab/full-screen-spike
Open

Full screen functionality for self hosted videos#15427
abeddow91 wants to merge 9 commits intomainfrom
ab/full-screen-spike

Conversation

@abeddow91
Copy link
Contributor

@abeddow91 abeddow91 commented Feb 25, 2026

What does this change?

Adds the functionality to full screen self hosted videos. This uses the fullscreen api.

This icon should not show for loop or cinemagraph style videos, only long-form video (currently called default)

The fullscreen icon renders in the same position as the mute button if the video does not have audio. If the video does have audio, the fullscreen icon appears next to the mute button. There has been a refactor to the CSS to place both button siblings within a wrapper.

Why?

This is a requirement for long form videos.

Screenshots

Screen.Recording.2026-02-25.at.16.18.58.mov
top control positioning bottom control positioning
top bottom

@abeddow91 abeddow91 self-assigned this Feb 25, 2026
@abeddow91 abeddow91 added fronts + curation feature Departmental tracking: work on a new feature run_chromatic Runs chromatic when label is applied labels Feb 25, 2026
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

@abeddow91 abeddow91 force-pushed the ab/full-screen-spike branch from 01c9329 to 181ebe2 Compare February 26, 2026 09:45
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Feb 26, 2026
@abeddow91 abeddow91 requested a review from domlander February 26, 2026 09:52
@abeddow91 abeddow91 added the run_chromatic Runs chromatic when label is applied label Feb 26, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Feb 26, 2026
@paperboyo
Copy link
Contributor

paperboyo commented Feb 26, 2026

Yay 👏 ! Some loose thoughts if I may (feel free to ignore):

  • would we allow double-click to enter/exit fullscreen?* (to be consistent with our youtube player and… the rest of the internetz)
  • here I’m conflicted, because I don’t know what solution I would propose. Habits form. Ideally, an icon should not change its place (fun). As I understand, the mute icon being optional, positions of both icons can change depending on the presence of the audio track… Not a huge issue: it’s unlikely anyone would be clicking these constantly to get annoyed by them changing positions. Nevertheless, it’s possible. Not sure of the solution, though… Simplest would be for the icons to have static positions and never move, but that would mean either a) it could look off with an empty space sometimes or b) mute would move between videos that have fullscreen and those that don’t. So, just wanted to mention in case someone smarter has an idea.

*I would even allow it (without icon) on loops and cinemagraphs (it’s there in the context menu anyway), but that’s less important

@abeddow91 abeddow91 force-pushed the ab/full-screen-spike branch from e1a771a to 0deed4b Compare February 26, 2026 11:27
@domlander
Copy link
Contributor

You may want to test the behaviour on mobile Safari, if you haven't already: https://caniuse.com/?search=exitFullscreen

@domlander
Copy link
Contributor

Going vertical instead of horizontal may be required to avoid clashing with subtitles. Test page
image

@abeddow91 abeddow91 force-pushed the ab/full-screen-spike branch from 6533458 to 746d852 Compare February 26, 2026 15:46
@abeddow91
Copy link
Contributor Author

You may want to test the behaviour on mobile Safari, if you haven't already: https://caniuse.com/?search=exitFullscreen

Thanks @domlander! You're quite right; fullscreen api is not available for mobile safari so i've added the webkit api for mobile safari users which fixes the issue

Simulator.Screen.Recording.-.iPhone.17.-.2026-02-26.at.15.38.38.mp4

@abeddow91 abeddow91 force-pushed the ab/full-screen-spike branch from de3eb09 to d98333e Compare February 26, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature fronts + curation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants