Full screen functionality for self hosted videos#15427
Open
Full screen functionality for self hosted videos#15427
Conversation
domlander
reviewed
Feb 25, 2026
01c9329 to
181ebe2
Compare
Contributor
|
Yay 👏 ! Some loose thoughts if I may (feel free to ignore):
*I would even allow it (without icon) on loops and cinemagraphs (it’s there in the context menu anyway), but that’s less important |
… both are visible at once
e1a771a to
0deed4b
Compare
Contributor
|
You may want to test the behaviour on mobile Safari, if you haven't already: https://caniuse.com/?search=exitFullscreen |
Contributor
|
Going vertical instead of horizontal may be required to avoid clashing with subtitles. Test page |
domlander
reviewed
Feb 26, 2026
domlander
reviewed
Feb 26, 2026
6533458 to
746d852
Compare
…already has access to video style
Contributor
Author
Thanks @domlander! You're quite right; fullscreen api is not available for mobile safari so i've added the webkit api for mobile safari users which fixes the issue Simulator.Screen.Recording.-.iPhone.17.-.2026-02-26.at.15.38.38.mp4 |
de3eb09 to
d98333e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this change?
Adds the functionality to full screen self hosted videos. This uses the fullscreen api.
This icon should not show for loop or cinemagraph style videos, only long-form video (currently called
default)The fullscreen icon renders in the same position as the mute button if the video does not have audio. If the video does have audio, the fullscreen icon appears next to the mute button. There has been a refactor to the CSS to place both button siblings within a wrapper.
Why?
This is a requirement for long form videos.
Screenshots
Screen.Recording.2026-02-25.at.16.18.58.mov