Use grid module for StandardLayout, introduce vertical rules#15428
Draft
frederickobrien wants to merge 3 commits intomainfrom
Draft
Use grid module for StandardLayout, introduce vertical rules#15428frederickobrien wants to merge 3 commits intomainfrom
StandardLayout, introduce vertical rules#15428frederickobrien wants to merge 3 commits intomainfrom
Conversation
frederickobrien
added
the
maintenance
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
from
c8e046d to
b0f4bf5
Compare
frederickobrien
changed the title
StandardLayoutStandardLayout
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
from
bb14535 to
b752a6f
Compare
frederickobrien
changed the title
StandardLayoutStandardLayout, introduce vertical rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change and why?
This refactors the
StandardLayoutto use thegridmodule, hopefully making it easier to reason with and style. This is with one eye on header standardisation work by @guardian/articles-and-publishing as well as a potential revamp of the interactive layout (see #15358).As part of this I've had a stab at introducing
verticalRulesto thegridmodule, allowing for lines to be added if they're wanted. This first pass at it feels a bit clunky - something that's pure CSS using:beforeor some such would be nice - but it works by god.Context
Screenshots