Skip to content

Address clang signed-unsigned warnings #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alt-graph merged 2 commits into from
May 27, 2026
Merged

Address clang signed-unsigned warnings #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29f33fd
Fix a signed-unsigned conversion warning issued by clang
alt-graph May 20, 2026
497a054
Address a signed-unsigned warning
alt-graph May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/gul17/string_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,14 @@ template <typename Iterator>
inline std::string
hex_string(Iterator begin, Iterator end, std::string_view separator = "")
{
const std::size_t n = std::distance(begin, end);
const auto range_length = std::distance(begin, end);

std::string result;

if (n > 0)
if (range_length > 0)
{
const auto n = static_cast<std::size_t>(range_length);

result.reserve(2 * sizeof(*begin) * n + separator.size() * (n - 1));

result += hex_string(*begin);
Expand Down
4 changes: 2 additions & 2 deletions src/string_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* \authors \ref contributors
* \date Created on 31 August 2018
*
* \copyright Copyright 2018-2025 Deutsches Elektronen-Synchrotron (DESY), Hamburg
* \copyright Copyright 2018-2026 Deutsches Elektronen-Synchrotron (DESY), Hamburg
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published
Expand Down Expand Up @@ -88,7 +88,7 @@ std::string_view safe_string_view(const char* char_ptr, std::size_t length)

auto end_ptr = std::find(char_ptr, char_ptr + length, '\0');

return std::string_view(char_ptr, end_ptr - char_ptr);
return std::string_view(char_ptr, static_cast<std::size_t>(end_ptr - char_ptr));
}

} // namespace gul17
Expand Down
4 changes: 2 additions & 2 deletions tests/test_escape.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* \date Created on August 31, 2018
* \brief Part of test suite for string utility functions in the General Utility Library.
*
* \copyright Copyright 2018-2025 Deutsches Elektronen-Synchrotron (DESY), Hamburg
* \copyright Copyright 2018-2026 Deutsches Elektronen-Synchrotron (DESY), Hamburg
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published
Expand Down Expand Up @@ -63,7 +63,7 @@ TEST_CASE("Check escaping and unescaping with random strings", "[escape]")
std::default_random_engine re(r());
std::uniform_int_distribution<unsigned short> uniform_dist(0, 255);

for (int len = 0; len < 100; len++)
for (std::size_t len = 0; len < 100u; ++len)
{
std::string original(len, ' ');

Expand Down
Loading