Recognise civic-tech-index as the Civic Tech Index project tag value - #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230.
The coverage script holds the five valid
projecttag values as a literalarray. #229 changed the canonical Civic Tech Index value to
civic-tech-indexon the wiki DR, leaving the array and the README list one entry stale.
The other four values were checked against decision 1 of
DR-Machine-to-machine-IAM-scoping and match.
Merge order: this first, hackforla/incubator#226 second. Between the two
merges the report is wrong either way, and this is the longer window: Civic Tech
Index's nine currently-tagged resources read as
nonconforminguntil #226applies. That is acceptable because the script is a read-only report and nothing
grants access on the basis of it — and #226 is blocked behind #223/#224/#225 and
needs a scheduled downtime window, so holding this PR for it would mean holding
it indefinitely.
Action item 5 —
./aws-terraform-coverage.ps1 -ProjectTagreporting zerononconforming resources — can only be checked once #226 has applied, as the
issue itself notes.