Skip to content

Modified current-projects.js to remove OR logic from project filter #8538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadilahmed wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
+5 −2
Open

Modified current-projects.js to remove OR logic from project filter #8538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions assets/js/current-projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ function updateProjectCardDisplayState(filterParams){
if(key !=='Search'){
let inUrl = value;
let inCard = projectCardObj[key];
if( ( inCard.filter(x => inUrl.includes(x)) ).length == 0 ){
if(!inUrl.every(x => inCard.includes(x))){
cardsToHideContainer.push([key,projectCard.id]);
}
else{
Expand Down Expand Up @@ -603,7 +603,10 @@ function updateProjectCardDisplayState(filterParams){
}
}
}
cardsToHideContainer.map(item => document.getElementById(`${item[1]}`).style.display = 'none');
if (cardsToHideContainer.length > 0){
cardsToHideContainer.map(item => document.getElementById(`${item[1]}`).style.display = 'none');
Copy link
Copy Markdown
Member

@viet456 viet456 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Since the issue instructions used .map() here, this isn't on you, but consider .forEach() instead.

cardsToHideContainer.forEach(item => document.getElementById(`${item[1]}`).style.display = 'none');

.map() is reserved for transformations that use the returned array. Here it's purely a side effect, which is what .forEach() is for.

It's non blocking, and you did follow the instructions well. Thanks for the contribution

break;
}
}
});
}
Expand Down